Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ec2_asg_tag module #482
Add ec2_asg_tag module #482
Changes from all commits
56657f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please import and use the
ansible_dict_to_boto3_tag_list
function from the module utility?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please import and use the
compare_aws_tags
function from the module utility?https://github.com/ansible-collections/amazon.aws/blob/main/plugins/module_utils/ec2.py#L783
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jillr this and the other requested changes weren't possible based on my testing.
ASG tags aren't just K/V pairs (as expected by
compare_aws_tags
,boto3_tag_list_to_ansible_dict
andansible_dict_to_boto3_tag_list
), they're a list of dicts instead. The ramification here is that ifpropagate_at_launch
is changed but the K/V doesn't, the module won't detect any tag changes which I believe is not the desired behaviour.Another issue I ran into was that the
to_text
andto_native
functions did some odd things, particularly aroundNone
values. Hence whycompare_asg_tags
doesn't use them likecompare_aws_tags
.From memory you can't roundtrip
None
liketo_native(to_text(None))
... or maybe it was the other way around? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for
boto3_tag_list_to_ansible_dict
:https://github.com/ansible-collections/amazon.aws/blob/main/plugins/module_utils/ec2.py#L465
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some tests for adding and removing tags in check_mode?