Stabilize and improve ec2_vpc_endpoint modules #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
jillr
force-pushed
the
cleanup_ec2_vpc_endpoint
branch
from
c758f69 to
70cbdea
Compare
jillr
changed the title
ansibullbot
added
community_review
needs_revision
goneri
reviewed
Mar 19, 2021
plugins/modules/ec2_vpc_endpoint.py
Outdated
| time.sleep(polling_increment_secs) | ||
| except (botocore.exceptions.ClientError, botocore.exceptions.BotoCoreError) as e: | ||
| module.fail_json_aws(e, msg='Failure while waiting for status') | ||
| def match_endpoints(module, endpoint): |
There was a problem hiding this comment.
You use module just to get access to the route_table_ids and service parameters. In order to reduce the inter-dependencies, I suggest to directly pass this two values to the function.
By doing so, it would be easier to write an unit-test.
There was a problem hiding this comment.
To be clear, this is a nitpicking level suggestion as I know we use to pass module everywhere.
There was a problem hiding this comment.
It's a good point though, and easily changed - thanks
goneri
approved these changes
Mar 19, 2021
ansibullbot
added
community_review
and removed
needs_revision
- Add tagging support - Make idempotent - Better exception handling - Better check_mode support - Use module_utils for common functions - Enable retries on common AWS failures
jillr
force-pushed
the
cleanup_ec2_vpc_endpoint
branch
from
2fa211b to
b2317d3
Compare
ansibullbot
added
needs_revision
tremble
requested changes
Mar 24, 2021
Comment on lines
+238
to
+239
| try: | ||
| result = client.describe_vpc_endpoints(aws_retry=True, **params) |
There was a problem hiding this comment.
Since we're cleaning up this should probably be moved to a paginated query, they seem to be more consistent than simple describe lookups.
ansibullbot
added
needs_revision
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…lections#473) * Stabilize and improve ec2_vpc_endpoint modules - Add tagging support - Make idempotent - Better exception handling - Better check_mode support - Use module_utils for common functions - Enable retries on common AWS failures * Make endpoint deletion idempotent in check_mode * Sanity fixes * Address review feedback This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@f1d338d
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Stabilize and improve ec2_vpc_endpoint modules - Add tagging support - Make idempotent - Better exception handling - Better check_mode support - Use module_utils for common functions - Enable retries on common AWS failures * Make endpoint deletion idempotent in check_mode * Sanity fixes * Address review feedback
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Stabilize and improve ec2_vpc_endpoint modules - Add tagging support - Make idempotent - Better exception handling - Better check_mode support - Use module_utils for common functions - Enable retries on common AWS failures * Make endpoint deletion idempotent in check_mode * Sanity fixes * Address review feedback
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* Stabilize and improve ec2_vpc_endpoint modules - Add tagging support - Make idempotent - Better exception handling - Better check_mode support - Use module_utils for common functions - Enable retries on common AWS failures * Make endpoint deletion idempotent in check_mode * Sanity fixes * Address review feedback
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
* Stabilize and improve ec2_vpc_endpoint modules - Add tagging support - Make idempotent - Better exception handling - Better check_mode support - Use module_utils for common functions - Enable retries on common AWS failures * Make endpoint deletion idempotent in check_mode * Sanity fixes * Address review feedback This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@f1d338d
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…ions#473) Add some integration tests for aws_service_ip_ranges SUMMARY Add some integration tests for aws_service_ip_ranges ISSUE TYPE Feature Pull Request COMPONENT NAME aws_service_ip_ranges ADDITIONAL INFORMATION Initial tests to support ansible-collections#430 Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ec2_vpc_endpoint
ec2_vpc_endpoint_info