Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more dependencies for unit-tests #458

Conversation

goneri
Copy link
Member

@goneri goneri commented Mar 4, 2021

No description provided.

@goneri goneri mentioned this pull request Mar 4, 2021
@goneri goneri force-pushed the test-add-more-dependencies-for-unit-tests_15225 branch from 27baa22 to b50a6fc Compare March 5, 2021 14:13
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mock's listed twice here and it's not entirely clear if it's pytest-mock + mock are what's referred to by your comment, or if placebo's intended to be avoided too.

Since I think you mean pytest-mock/mock should be avoided I'd suggest bumping placebo above the comment.

@goneri goneri force-pushed the test-add-more-dependencies-for-unit-tests_15225 branch 2 times, most recently from 83d390a to ded6a70 Compare March 5, 2021 15:19
@goneri goneri force-pushed the test-add-more-dependencies-for-unit-tests_15225 branch from ded6a70 to da5571d Compare March 5, 2021 16:52
@goneri goneri merged commit ea3a52d into ansible-collections:main Mar 5, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…ons#458)

Adding example of using groups in aws_ec2.py module

SUMMARY
Adding a example of using groups option to add items from a specific inventory configuration to groups.
Example shows use of groups to group hosts based on vpc id.
Resolves ansible-collections#412

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

aws_ec2.py

Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Abhijeet Kasurde <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants