Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sns_topic: Allow canonical international-format phone numbers in SMS subscriptions #454

Merged
merged 4 commits into from
Mar 8, 2021
Merged

sns_topic: Allow canonical international-format phone numbers in SMS subscriptions #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
519603c
Update sns_topic.py
overhacked Mar 3, 2021
5d8a889
Add changelog fragment for #454
overhacked Mar 5, 2021
98e0f2e
sns_topic: comment explaining SMS canonicalization
overhacked Mar 6, 2021
8c59a2f
sns_topic: fix changelog
overhacked Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/454-sns_topic_fix_sms_endpoint_canonicalization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- sns_topic - Add ``+`` to allowable characters in SMS endpoints (https://github.com/ansible-collections/community.aws/pull/454).
5 changes: 4 additions & 1 deletion plugins/modules/sns_topic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,8 +349,11 @@ def _set_topic_attrs(self):
return changed

def _canonicalize_endpoint(self, protocol, endpoint):
# AWS SNS expects phone numbers in
# and canonicalizes to E.164 format
# See <https://docs.aws.amazon.com/sns/latest/dg/sms_publish-to-phone.html>
if protocol == 'sms':
return re.sub('[^0-9]*', '', endpoint)
return re.sub('[^0-9+]*', '', endpoint)
return endpoint

def _set_topic_subs(self):
Expand Down