Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability - s3_lifecycle #448

Merged
merged 12 commits into from
Mar 25, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Feb 28, 2021

SUMMARY

Attempt to get the s3_lifecycle tests back in service

  • Use AWSRetry
  • Add waiters
  • Fix "changed" behaviour when dealing with dates
ISSUE TYPE
  • Feature Pull Request
  • Tests Pull Request
COMPONENT NAME

s3_lifecycle

ADDITIONAL INFORMATION

DEPENDS-ON: ansible-collections/amazon.aws#271

@ansibullbot
Copy link

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Feb 28, 2021
@tremble tremble force-pushed the reenable/s3_lifecycle branch from b07817a to 958bc6e Compare March 13, 2021 06:48
@tremble tremble force-pushed the reenable/s3_lifecycle branch 2 times, most recently from fafc84a to 63170a4 Compare March 15, 2021 15:22
@tremble tremble force-pushed the reenable/s3_lifecycle branch from 63170a4 to 958ec4a Compare March 15, 2021 15:48
@tremble tremble changed the title [WIP] Stability - s3_lifecycle Stability - s3_lifecycle Mar 15, 2021
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Mar 15, 2021
@tremble tremble requested review from jillr and alinabuzachis March 24, 2021 20:13
plugins/modules/s3_lifecycle.py Outdated Show resolved Hide resolved
plugins/modules/s3_lifecycle.py Show resolved Hide resolved
@tremble
Copy link
Contributor Author

tremble commented Mar 25, 2021

Tests passing and approval in place. Merging

@tremble tremble merged commit 9c0967c into ansible-collections:main Mar 25, 2021
@tremble tremble deleted the reenable/s3_lifecycle branch June 29, 2021 12:56
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
* Add aws retry
* re-enable lifecycle tests
* changelog
* Rename S3 bucket used by tests
* Cleanup docs
* Use datetime to be a little more flexible with the date formats
* Rework and add support for waiting for changes to propagate
* Wait for changes to propagate in tests s3 lifecycle events are especially susceptible to eventual consistency
* Test examples are also idempotent...
* More changelogs
* Catch Amazon's "Nothing Changed" error (can happen when just trying to enable/disable a rule)
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
* Add aws retry
* re-enable lifecycle tests
* changelog
* Rename S3 bucket used by tests
* Cleanup docs
* Use datetime to be a little more flexible with the date formats
* Rework and add support for waiting for changes to propagate
* Wait for changes to propagate in tests s3 lifecycle events are especially susceptible to eventual consistency
* Test examples are also idempotent...
* More changelogs
* Catch Amazon's "Nothing Changed" error (can happen when just trying to enable/disable a rule)
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
* Add aws retry
* re-enable lifecycle tests
* changelog
* Rename S3 bucket used by tests
* Cleanup docs
* Use datetime to be a little more flexible with the date formats
* Rework and add support for waiting for changes to propagate
* Wait for changes to propagate in tests s3 lifecycle events are especially susceptible to eventual consistency
* Test examples are also idempotent...
* More changelogs
* Catch Amazon's "Nothing Changed" error (can happen when just trying to enable/disable a rule)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants