[WIP] Stabilize ec2_vpc_nat_gateway #437
Conversation
* Add additional integration tests for ec2_vpc_nat_gateway_info and ec2_vpc_nat_gatewy modules
* Add ec2_vpc_nat_gateway_info in aliases
* Fix NAT gateway search
Signed-off-by: Alina Buzachis <[email protected]>
…tests Signed-off-by: Alina Buzachis <[email protected]>
* fix broken check_mode * uncomment integration tests in check_mode Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
ansibullbot
added
WIP
|
Hi @alinabuzachis, I have also done some work on stabilising these tests: #427 I tried to limit the changes to just those needed for stability, oddly enough the retry decorator on its own didn't seem to fix the issue, some of the time searches just weren't finding resources, and re-ran the create calls. I found that using a paginator on the filtered describe calls seemed to mean that we get results more consistently. I really like that you're cleaning up the check_mode tests in this PR. Given you're only using |
|
Hi @tremble, I realised you were working on the nat gateway stabilisation only after opening the PR. I agree with you to merge your PR first. |
|
Closing this off as a duplicate. We may want to pull the docs cleanup into its own PR. |
…ections#437) ec2_ami - ensure tags are propagated to the snapshot(s) SUMMARY ec2_ami - ensure tags are propagated to the snapshot(s) when creating an AMI. Fixes ansible-collections#368 Using --tag-specifications would introduce additional complexity for handling tags within the ec2_ami module. A simple approach would be to ensure tags propagation during AMI creation to the snapshot(s) and then edit snapshot(s) tags using the ec2_tag module. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_ami Reviewed-by: Jill R <None> Reviewed-by: None <None>
SUMMARY
Stabilize ec2_vpc_nat_gateway module
Depends on https://github.com/ansible-collections/community.aws/pull/436
COMPONENT NAME
ec2_vpc_nat_gateway