Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the ec2_vpc_nat_gateway integration tests 'unstable' #429

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Feb 20, 2021

SUMMARY

See also #428

ISSUE TYPE
  • Tests Pull Request
COMPONENT NAME

ec2_vpc_nat_gateway

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review integration tests/integration needs_triage plugins plugin (any type) small_patch Hopefully easy to review tests tests labels Feb 20, 2021
@tremble
Copy link
Contributor Author

tremble commented Feb 20, 2021

Failed tests prove the point ;)

@tremble tremble merged commit cd1430d into ansible-collections:main Feb 20, 2021
@tremble tremble deleted the mark-unstable/ec2_vpc_nat_gateway branch June 29, 2021 12:55
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…s#429)

Disable ec2_key, ec2_snapshot and ec2_group tests

SUMMARY
Work around ansible-collections#428 and ansible-collections#440 ansible-collections#441
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_key
ec2_snapshot
ec2_group
ADDITIONAL INFORMATION

Reviewed-by: Jill R <None>
Reviewed-by: None <None>
Reviewed-by: Paul Belanger <None>
Reviewed-by: Mark Chappell <None>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…ollections#436)

ec2_group: update documentation for specifying port ranges

Depends-on: ansible-collections#429
SUMMARY

Added missing part of documentation for specifying port ranges as -1 value in parameter from_port and to_port is only supported for proto:icmp.
Fixes ansible-collections#397

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

ec2_group

Reviewed-by: Jill R <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review integration tests/integration needs_triage plugins plugin (any type) small_patch Hopefully easy to review tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants