Remove ec2_vpc_nat_gateway unit tests #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t based on the hard coded check_mode results any more
ansibullbot
added
community_review
integration
jillr
approved these changes
Feb 11, 2021
ethemcemozkan
pushed a commit
to ethemcemozkan/community.aws
that referenced
this pull request
Feb 18, 2021
* Remove ec2_vpc_nat_gateway unit tests * update comments in ec2_vpc_nat_gateway integration tests - they're not based on the hard coded check_mode results any more
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Remove ec2_vpc_nat_gateway unit tests * update comments in ec2_vpc_nat_gateway integration tests - they're not based on the hard coded check_mode results any more
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Remove ec2_vpc_nat_gateway unit tests * update comments in ec2_vpc_nat_gateway integration tests - they're not based on the hard coded check_mode results any more
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* Remove ec2_vpc_nat_gateway unit tests * update comments in ec2_vpc_nat_gateway integration tests - they're not based on the hard coded check_mode results any more
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
Formally start the ec2 deprecation process SUMMARY The ec2 module is based upon the deprecated boto (not boto3/botocore) SDK and most functionality has been replaced by the ec2_instance module. Formally start the deprecation process and give it 2 major releases. For practical purposes the ec2 module has a number of limitations (things like not supporting all regions) and we're still getting bugs filed against it for quirky behaviour that's fixed in ec2_instance. By formally starting the deprecation process we can move most folks over to ec2_instance where possible and avoid trying to support 2 modules at the same time. The major missing feature with the ec2_instance module is spot instances. Support for spot instances is underway in ansible-collections#407 Should spot instance support not be available by 3.0.0 we can always extend the deprecation period. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2 ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: None <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
* Remove ec2_vpc_nat_gateway unit tests * update comments in ec2_vpc_nat_gateway integration tests - they're not based on the hard coded check_mode results any more This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@701153a
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
Add initial work on new spot instance module SUMMARY Working on a new EC2 spot instance module ISSUE TYPE New Module Pull Request COMPONENT NAME ec2_spot_instance ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: Rachana <[email protected]> Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The ec2_vpc_nat_gateway unit tests rely on hard-coded "check_mode" return values.
We now have integration tests with better (real) coverage than the unit tests which were broken by #372. IMO leaving the unit tests there will only discourage people from making check_mode behave properly.
ISSUE TYPE
COMPONENT NAME
ec2_vpc_nat_gateway
ADDITIONAL INFORMATION
Also removed the comment from the integration tests which implied they were based on the fake check_mode behaviour which had hard coded return values.