Fix UnboundLocalError in sqs_queue

[leedm777]

SUMMARY

The variable existing_value is nowhere to be found, but looks like
this might have been missed in a rename. Changing to value.

Fixes #172

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

sqs_queue

ADDITIONAL INFORMATION

See details in #172

[ansibullbot]

cc @jillr @loia @nand0p @s-hertel @sbj-ss @tremble @wimnat
click here for bot help

[cmpsoares91]

Hello,

When can we expect this merge to happen?

Kind regards,
Carlos Manuel Soares.

[jillr]

Hi @leedm777, thanks very much for this patch. It looks like this bug was missed because we don't have any integration tests that exercise update_sqs_queue. Would you be able to add some tests (ansible tasks) to tests/integration/targets/sqs_queue/tasks/main.yml that test update functionality?

[leedm777]

@jillr ,

Would you be able to add some tests (ansible tasks) to tests/integration/targets/sqs_queue/tasks/main.yml that test update functionality?

Absolutely. I don't see any instructions on how to run the tests; can you point me in the right direction? Once I can run them, then I'll be able to write some new tests😄

[jillr]

You can always just push the changes to the PR and CI will run them for you, if you want to use you own account locally you can run the integration test locally by copying this config file https://github.com/ansible/ansible/blob/devel/test/lib/ansible_test/config/cloud-config-aws.ini.template to tests/integration/cloud-config-aws.ini (we have a .gitignore entry for that filename but still be careful of credentials files). Then you can run:
ansible-test integration cloudwatchevent_rule --docker to pull the test container and run the test against your own AWS account.

[tremble]

I've added a minimal integration test and a changelog.

[tremble]

change LGTM.

The test's straight out of the examples and I've tested locally with and without the change. Assuming all tests pass let's get this merged.

[tremble]

@leedm777,

Thanks for your contribution. I'm sorry it took so long to get this PR merged. The fix should be available in the next versions of Ansible 2.10 and this collection.