-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add uptime parameter for ec2_instance_info module in minutes #356
Conversation
with tons of help from Yanis, we now have uptime in there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to submit this PR.
Some minor issues, but nothing significant from my side.
tests/integration/targets/ec2_instance/roles/ec2_instance/tasks/uptime.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/ec2_instance/roles/ec2_instance/tasks/uptime.yml
Show resolved
Hide resolved
tests/integration/targets/ec2_instance/roles/ec2_instance/tasks/uptime.yml
Outdated
Show resolved
Hide resolved
adding to ansible-collections#356 with comments from @tremble and @duderamos
@tremble , I think I made all the changes... can you verify for me 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good from my side. Could you add a changelog fragment? https://docs.ansible.com/ansible/latest/community/development_process.html#community-changelogs
adding changelog fragment per @gravesm suggestion
should be there now @gravesm ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweak in wording, but otherwise I think we're good
@@ -0,0 +1,3 @@ | |||
--- | |||
minor_changes: | |||
- adding minimum_uptime and alias uptime to filter instances that have only been online for certain duration of time in minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- adding minimum_uptime and alias uptime to filter instances that have only been online for certain duration of time in minutes | |
- ec2_instance_info - added ``minimum_uptime`` option with alias ``uptime`` for filtering instances that have only been online for certain duration of time in minutes (https://github.com/ansible-collections/community.aws/pull/356). |
last comment from @tremble
ok made the change, thanks for all the help @tremble |
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
ec2_snapshot - boto3 migration Reviewed-by: Mark Chappell https://github.com/tremble
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
SUMMARY
with tons of help from Yanis, we now have uptime in there
this PR is based on the PR #316
example:
this would only register instances that have been up for 10200 minutes (or 170 hours or ~7 days)
ISSUE TYPE
COMPONENT NAME
ec2_instance_info
ADDITIONAL INFORMATION
see #316 for the commentary on the last PR where I fixed information for @jillr and @gravesm