Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch Template cleanup retries and add tests into CI #326

Merged
merged 9 commits into from
Dec 15, 2020

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Dec 10, 2020

SUMMARY

Enable Launch Template tests in CI

Todo:

  • CI Policy
  • Terminator support for Launch Templates
  • Fix policy used by Role tests
  • Make sure aws_retry is enabled where expected
  • changelog
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_launch_template

ADDITIONAL INFORMATION

See also: #322

@tremble tremble force-pushed the tests/launch_template branch from de20395 to 1cd500e Compare December 14, 2020 19:59
@tremble tremble changed the title [WIP] Get Launch Template tests into CI Launch Template cleanup retries and add tests into CI Dec 14, 2020
@tremble tremble requested a review from jillr December 14, 2020 21:02
@jillr jillr merged commit 4ad9fd3 into ansible-collections:main Dec 15, 2020
@tremble tremble deleted the tests/launch_template branch February 11, 2021 09:25
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…tions#326)

* Mark ec2_launch_template tests as supported

* Update launch template test to use permitted harmless managed policy

* Make sure we delete the instance profile

* Cleanup imports

* use ansible_dict_to_boto3_tag_list

* Make sure retries are enabled

* Update role names in line with CI policy

* Lookup AMI name rather than hardcoding IDs

* Add changelog fragment
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…tions#326)

* Mark ec2_launch_template tests as supported

* Update launch template test to use permitted harmless managed policy

* Make sure we delete the instance profile

* Cleanup imports

* use ansible_dict_to_boto3_tag_list

* Make sure retries are enabled

* Update role names in line with CI policy

* Lookup AMI name rather than hardcoding IDs

* Add changelog fragment
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
…tions#326)

* Mark ec2_launch_template tests as supported

* Update launch template test to use permitted harmless managed policy

* Make sure we delete the instance profile

* Cleanup imports

* use ansible_dict_to_boto3_tag_list

* Make sure retries are enabled

* Update role names in line with CI policy

* Lookup AMI name rather than hardcoding IDs

* Add changelog fragment
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants