Add additional storage classes to S3 lifecycle transition list. #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
requested changes
Oct 20, 2020
There was a problem hiding this comment.
Unfortunately the integration tests are apparently broken (not because of this change)
Rather than blocking a very simple improvement on fixing the tests I think we can let this one through on the basis of the updated docs:
@philltomlinson One small thing: Please add a "minor changes" changelog entry: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
tremble
approved these changes
Oct 20, 2020
changelogs/fragments/270_add_additional_storage_classes_to_S3_lifecycle_transition_list.yml
Outdated
Show resolved
Hide resolved
…lifecycle_transition_list.yml
|
@philltomlinson Thank you for taking the time to raise this PR. |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ble-collections#270) * Add additional storage classes to S3 lifecycle transition list. * Add minor changes changelog for S3 lifecycle transition list change.
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ble-collections#270) * Add additional storage classes to S3 lifecycle transition list. * Add minor changes changelog for S3 lifecycle transition list change.
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…s#270) * Add vpc_available, vpc_exists and subnet_available waiters * ec2_vpc_subnet use retry decorators more consistently * ec2_vpc_net: Use custom waiter that handles API Ratelimits * Move Client/BotoCore Error catching inside get_classic_link function * Catch WaiterError to give a better error message * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.