Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch ImportError rather than Exception when testing Boto3 imports #267

Merged
merged 1 commit into from
Oct 19, 2020
Merged

catch ImportError rather than Exception when testing Boto3 imports #267

merged 1 commit into from
Oct 19, 2020

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 19, 2020

SUMMARY

Cleanup for consistency.

Catching Exception is generally considered bad. Our boto3/botocore import stanzas generally use ImportError instead.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/aws_direct_connect_confirm_connection.py
plugins/modules/aws_direct_connect_connection.py
plugins/modules/aws_direct_connect_link_aggregation_group.py
plugins/modules/aws_s3_cors.py
plugins/modules/ec2_transit_gateway.py
plugins/modules/ec2_transit_gateway_info.py
plugins/modules/lambda_policy.py
plugins/modules/rds_snapshot_info.py

ADDITIONAL INFORMATION

@tremble tremble requested a review from jillr October 19, 2020 15:20
@jillr jillr merged commit e83d579 into ansible-collections:main Oct 19, 2020
@tremble tremble deleted the cleanup/import_exception branch February 11, 2021 09:14
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@tremble
catch ImportError rather than Exception when testing Boto3 imports (a…
d22ca31 
…nsible-collections#267)
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@tremble
catch ImportError rather than Exception when testing Boto3 imports (a…
1429303 
…nsible-collections#267)
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @goneri
catch ImportError rather than Exception when testing Boto3 imports (a…
8e3e219 
…nsible-collections#267)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@e83d579
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @goneri
catch ImportError rather than Exception when testing Boto3 imports (a…
387262c 
…nsible-collections#267)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@e83d579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremble @jillr