Allow ECS.Client.delete_service to force delete a service

[asaf400]

SUMMARY

Change allows ansible to forcefully delete a service,
required when deleting a service with >0 scale, or no target group

ISSUE TYPE

#220

COMPONENT NAME

ecs_service

[asaf400]

I do not know how to setup shippable for local debugging before submitting the PR, And I did not find any information about this.
I am sorry if this PR is currently in a state of garbage, while I iron out the tests for the changes.. (Help is appreciated)

[ansibullbot]

cc @Java1Guy @jillr @kaczynskid @s-hertel @tremble @wimnat @zacblazic
click here for bot help

[ansibullbot]

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

plugins/modules/ecs_service.py:0:0: doc-required-mismatch: Argument 'force_deletion' in argument_spec is required, but is not documented as being required
plugins/modules/ecs_service.py:0:0: no-default-for-required-parameter: Argument 'force_deletion' in argument_spec is marked as required but specifies a default. Arguments with a default should not be marked as required
plugins/modules/ecs_service.py:0:0: parameter-type-not-in-doc: Argument 'force_deletion' in argument_spec defines type as 'bool' but documentation doesn't define type
plugins/modules/ecs_service.py:0:0: undocumented-parameter: Argument 'force_deletion' is listed in the argument_spec, but not documented in the module documentation

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

plugins/modules/ecs_service.py:0:0: no-default-for-required-parameter: Argument 'force_deletion' in argument_spec is marked as required but specifies a default. Arguments with a default should not be marked as required
plugins/modules/ecs_service.py:0:0: parameter-type-not-in-doc: Argument 'force_deletion' in argument_spec defines type as 'bool' but documentation doesn't define type
plugins/modules/ecs_service.py:0:0: undocumented-parameter: Argument 'force_deletion' is listed in the argument_spec, but not documented in the module documentation

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

plugins/modules/ecs_service.py:0:0: doc-required-mismatch: Argument 'force_deletion' in argument_spec is required, but is not documented as being required
plugins/modules/ecs_service.py:0:0: no-default-for-required-parameter: Argument 'force_deletion' in argument_spec is marked as required but specifies a default. Arguments with a default should not be marked as required
plugins/modules/ecs_service.py:0:0: parameter-type-not-in-doc: Argument 'force_deletion' in argument_spec defines type as 'bool' but documentation doesn't define type
plugins/modules/ecs_service.py:0:0: undocumented-parameter: Argument 'force_deletion' is listed in the argument_spec, but not documented in the module documentation

click here for bot help

[gundalow]

@asaf400 You can run the tests locally, have a look at https://www.katacoda.com/ansible-community/scenarios/fixing-a-bug for an example walk through of how to do this

[gundalow]

Please add the following into the DOCUMENTATION block after line 118

    force_deletion:
        description:
          - Forcabily delete the service. Required when deleting a service with >0 scale, or no target group.
        default: False
        type: bool

[asaf400]

I think I still have a bit of work on 'tests/integration/targets/ecs_cluster/tasks/force_service_deletion.yml'
I'm not sure if I'm done with that file, I'll try to make sure it looks okay during this week..

Edit: Also, Done pushing documentation block commit

[ansibullbot]

@asaf400 This PR contains @ mentions in at least one commit message. Those mentions can cause cascading notifications through GitHub and need to be removed. Please squash or amend your commits to remove the mentions.

click here for bot help

[ansibullbot]

cc @markuman
click here for bot help

[tremble]

rebased, tested locally and added some missing documentation (changelog / version_added)

[tremble]

I'm sorry it's taken so long to get this merged. I've fixed up the tests and added some minor documentation but I think this is now ready to merge.

[ansible-zuul]

LGTM!