Bugfix/ec2 instance mod sgs #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally switch from *_facts to *_info
tremble
requested changes
May 7, 2020
Co-authored-by: Mark Chappell <[email protected]>
Co-authored-by: Mark Chappell <[email protected]>
Instead of looping over the param_mapping for security groups they are called out specifically. Refs #21
s-hertel
reviewed
Jul 10, 2020
plugins/modules/ec2_instance.py
Outdated
| default_vpc = get_default_vpc(ec2) | ||
| if default_vpc is None: | ||
| module.fail_json( | ||
| msg="No default subnet could be found - you must include a VPC subnet ID (vpc_subnet_id parameter) to create an instance") |
There was a problem hiding this comment.
This error should probably be about modifying security groups instead of creating an instance
There was a problem hiding this comment.
What do you think about the new verbiage?
When a subnet is not defined and cannot be found generate an error message that reflects operating on a security group. Refs #21
tremble
approved these changes
Aug 16, 2020
|
I've added a changelog fragment but I think we're good to merge this now. |
This was referenced Aug 28, 2020
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
Fixes #54174 * Added SG handling for existing instances + some cleanup * tests(ec2_instance): Tests for SG modifications to existing instances * tests(ec2_instance): Test simultaneous state and SG changes * refactor(ec2_instance): Move security out of for loop * style(ec2_instance): Update fail message to reflect security groups * Add changelog Co-authored-by: Andrea Tartaglia <[email protected]> Co-authored-by: Mark Chappell <[email protected]>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
Fixes #54174 * Added SG handling for existing instances + some cleanup * tests(ec2_instance): Tests for SG modifications to existing instances * tests(ec2_instance): Test simultaneous state and SG changes * refactor(ec2_instance): Move security out of for loop * style(ec2_instance): Update fail message to reflect security groups * Add changelog Co-authored-by: Andrea Tartaglia <[email protected]> Co-authored-by: Mark Chappell <[email protected]>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…tions#22) * Change github url in galaxy.yml from git@ to https://
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
Fixes #54174 * Added SG handling for existing instances + some cleanup * tests(ec2_instance): Tests for SG modifications to existing instances * tests(ec2_instance): Test simultaneous state and SG changes * refactor(ec2_instance): Move security out of for loop * style(ec2_instance): Update fail message to reflect security groups * Add changelog Co-authored-by: Andrea Tartaglia <[email protected]> Co-authored-by: Mark Chappell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This fixes the issue below, where security groups were not changed if the instance already existed.
Fixes #21
ISSUE TYPE
COMPONENT NAME
ec2_instance.py
ADDITIONAL INFORMATION
See ansible/ansible#67778 and ansible/ansible#55712 for previous discussions.