aws_ssm connection plugin: add STS token parameters. #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ansible-collections#24 Add the following parameters to aws_ssm.py connection plugin: * ansible_aws_ssm_access_key_id * ansible_aws_ssm_secret_access_key * ansible_aws_ssm_session_token Co-authored-by: Mark Chappell <[email protected]>
gau1991
approved these changes
Sep 2, 2020
tremble
approved these changes
Sep 2, 2020
changelogs/fragments/25-add-sts-token-to-aws-ssm-conn-plugin.yaml
Outdated
Show resolved
Hide resolved
|
thanks @tremble and sorry for the pr mess |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ions#218) * aws_ssm connection plugin: add STS token parameters. Fixes ansible-collections#24 Add the following parameters to aws_ssm.py connection plugin: * ansible_aws_ssm_access_key_id * ansible_aws_ssm_secret_access_key * ansible_aws_ssm_session_token
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ions#218) * aws_ssm connection plugin: add STS token parameters. Fixes ansible-collections#24 Add the following parameters to aws_ssm.py connection plugin: * ansible_aws_ssm_access_key_id * ansible_aws_ssm_secret_access_key * ansible_aws_ssm_session_token
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
The `ForwardConfig` key of the action is optional. Its presence during the `compare_listeners()` or `compare_rules()` evaluation breaks the comparison between the expectation and current state. With this patch, we ignore the key IF this structure is not required. Closes: ansible-collections#218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #24
Add the following parameters to aws_ssm.py connection plugin:
ISSUE TYPE
COMPONENT NAME
This implements some basic STS token management, that can be passed as parameters to the task when the aws_ssm connection plugin is involved, the parameters are scoped to the plugin namespace.
ADDITIONAL INFORMATION
If you have a role that you allowed to assume in a target account, you would need to assume such role in the target account before invoking the task; this example comes from an invocation by using ansible APIs, where even assuming the role in the target account, the connection plugin was still executing under the controller-node account session.
By implementing the changes in this PR I am able to pass an STS token as a parameter to the task, letting it execute under the target account context.
This change also allows for backward compatibility as if nothing is specified (no OS environment variables, no parameters) the boto3 client will automatically select the
defaultprofile configured on the controller.