Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "DNM Migrate elb_classic_lb_info* modules and tests (#2163)" #2170

Merged

Conversation

mandar242
Copy link
Contributor

@mandar242 mandar242 commented Oct 8, 2024

This reverts commit 7f11acb.

Reverts #2163

#2163 changes are being reverted as it has been agreed to hold off on merging the migration PRs until a plan is set to migrate all planned modules at once. We need to disable the squash strategy in github first to retain commit history.

SUMMARY

Copy link

github-actions bot commented Oct 8, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/39f593b8c6de40b3ae7e26db2051e95c

✔️ ansible-galaxy-importer SUCCESS in 3m 20s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 42s
✔️ ansible-test-splitter SUCCESS in 4m 29s
✔️ integration-community.aws-1 SUCCESS in 16m 38s
✔️ integration-community.aws-2 SUCCESS in 5m 14s
Skipped 20 jobs

Copy link
Collaborator

@GomathiselviS GomathiselviS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include a brief description in the PR explaining why the changes are being reverted? This will provide context for future reference.

@mandar242 mandar242 added the mergeit Merge the PR (SoftwareFactory) label Oct 9, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/7148e580e2a644228aea6281704f0acd

ansible-galaxy-importer FAILURE in 4m 53s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 40s
✔️ ansible-test-splitter SUCCESS in 4m 20s
✔️ integration-community.aws-1 SUCCESS in 14m 23s
✔️ integration-community.aws-2 SUCCESS in 7m 03s
Skipped 20 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4cf5a6f into main Oct 10, 2024
63 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the revert-2163-promote_elb_classic_lb_info branch October 10, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants