Refactor ec2_vpc_peer* modules #2153
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
alinabuzachis
force-pushed
the
ec2_vpc_peer_refactor
branch
from
3b8bd11 to
d954ee2
Compare
|
This change depends on a change that failed to merge. Change ansible-collections/amazon.aws#2303 is needed. |
alinabuzachis
force-pushed
the
ec2_vpc_peer_refactor
branch
from
d954ee2 to
8c2ee6b
Compare
|
This change depends on a change that failed to merge. Change ansible-collections/amazon.aws#2303 is needed. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 23s (non-voting) |
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
ec2_vpc_peer_refactor
branch
from
0e76c5e to
7f67600
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 29s (non-voting) |
Signed-off-by: Alina Buzachis <[email protected]>
|
This change depends on a change that failed to merge. Change ansible-collections/amazon.aws#2303 is needed. |
Signed-off-by: Alina Buzachis <[email protected]>
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 43s (non-voting) |
|
recheck |
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 55s (non-voting) |
|
recheck |
1 similar comment
|
recheck |
Signed-off-by: Alina Buzachis <[email protected]>
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 50s (non-voting) |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 22s (non-voting) |
plugins/modules/ec2_vpc_peer.py
Outdated
| "status-code": state, | ||
| } | ||
| try: | ||
| waiter.wait(Filters=ansible_dict_to_boto3_filter_list(peer_filter)) | ||
| waiter.wait(Filters=ansible_dict_to_boto3_filter_list(filters)) | ||
| except botocore.exceptions.WaiterError as e: | ||
| module.fail_json_aws(e, "Failed to wait for state change") | ||
| except (botocore.exceptions.ClientError, botocore.exceptions.BotoCoreError) as e: | ||
| module.fail_json_aws(e, "Enable to describe Peerig Connection while waiting for state to change") |
There was a problem hiding this comment.
Should the message be "Unable to describe Peerig Connection while waiting for state to change" ?
| register: peers_info | ||
| check_mode: True | ||
|
|
||
| - name: Assert success | ||
| assert: |
There was a problem hiding this comment.
| assert: | |
| ansible.builtin.assert: |
There was a problem hiding this comment.
Can you add FQCN for all assert tasks ?
plugins/modules/ec2_vpc_peer.py
Outdated
| peering_connections = describe_vpc_peering_connections( | ||
| client, Filters=ansible_dict_to_boto3_filter_list(filters) | ||
| ) | ||
| except AnsibleEC2Error as e: |
There was a problem hiding this comment.
Won't a.aws' ec2 module_utils manage this error?
There was a problem hiding this comment.
I thought the errors need to be handled here.
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
ec2_vpc_peer_refactor
branch
from
12006f5 to
c01f5f0
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 46s (non-voting) |
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 24s (non-voting) |
Signed-off-by: Alina Buzachis <[email protected]>
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 15s (non-voting) |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 44s (non-voting) |
softwarefactory-project-zuul
bot
merged commit fcd780e
into
ansible-collections:main
SUMMARY
Depends-On: ansible-collections/amazon.aws#2303
Refactor ec2_vpc_peer* modules
Once the module is migrated to amazon.aws I will deprecate
resultreturned by the info module and rename the ec2_vpc_peer module (see #2154).ISSUE TYPE
COMPONENT NAME
ec2_vpc_peer
ec2_vpc_peering_info
ADDITIONAL INFORMATION