Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag support to ec2_placement_group #2081

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Add tag support to ec2_placement_group #2081

merged 1 commit into from
Aug 1, 2024

Conversation

harisokanovic
Copy link
Contributor

SUMMARY

Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.

ISSUE TYPE
  • Feature Pull Request

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3cfa2743cc274cfd89151ea892b56fbb

❌ ansible-galaxy-importer FAILURE in 5m 46s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 54s
✔️ ansible-test-splitter SUCCESS in 5m 44s
✔️ integration-community.aws-1 SUCCESS in 7m 55s
Skipped 21 jobs

@markuman
Copy link
Member

@harisokanovic Thanks for your contribution. We'll also need a changelog fragment. Otherwise, LGTM.

@harisokanovic harisokanovic force-pushed the dev/harisokn/pg-tags branch 2 times, most recently from 8e46164 to 394bbdc Compare June 14, 2024 00:43
@harisokanovic
Copy link
Contributor Author

@harisokanovic Thanks for your contribution. We'll also need a changelog fragment. Otherwise, LGTM.

Hi Markus, thanks for looking it over. I pushed an updated branch with your suggestions and a changelog fragment.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ee566acb948c44f4b7b4924957840a3d

✔️ ansible-galaxy-importer SUCCESS in 4m 08s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 52s
✔️ ansible-test-splitter SUCCESS in 5m 17s
✔️ integration-community.aws-1 SUCCESS in 10m 37s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0ec61a12dbcc469482294a970a2b00bb

❌ ansible-galaxy-importer FAILURE in 4m 53s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 58s
✔️ ansible-test-splitter SUCCESS in 5m 14s
✔️ integration-community.aws-1 SUCCESS in 5m 48s
Skipped 21 jobs

tremble
tremble previously requested changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Our's linter's complaining about some whitespace, but nothing major.

plugins/modules/ec2_placement_group_info.py Show resolved Hide resolved
plugins/modules/ec2_placement_group_info.py Show resolved Hide resolved
@harisokanovic harisokanovic force-pushed the dev/harisokn/pg-tags branch from cd4c605 to 6988d1e Compare June 14, 2024 15:29
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0a753632fc0e47cbabc38f957a4d9507

✔️ ansible-galaxy-importer SUCCESS in 9m 51s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 52s
✔️ ansible-test-splitter SUCCESS in 5m 38s
✔️ integration-community.aws-1 SUCCESS in 9m 20s
Skipped 21 jobs

@harisokanovic
Copy link
Contributor Author

Hi @tremble @markuman, I believe all feedback was addressed in the latest update, and the bots now appear happy. Please let me know if I missed anything.

@markuman markuman requested a review from tremble June 18, 2024 05:18
@harisokanovic harisokanovic force-pushed the dev/harisokn/pg-tags branch from 6988d1e to 86e3163 Compare June 18, 2024 22:14
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3ef7f7f0064f428283b4b67f198b598b

✔️ ansible-galaxy-importer SUCCESS in 3m 57s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 52s
✔️ ansible-test-splitter SUCCESS in 5m 16s
✔️ integration-community.aws-1 SUCCESS in 10m 00s
Skipped 21 jobs

@alinabuzachis alinabuzachis requested a review from markuman July 2, 2024 16:09
@harisokanovic
Copy link
Contributor Author

Two tests failed with this doc error:

ERROR: Found 1 validate-modules issue(s) which need to be resolved:
ERROR: plugins/inventory/aws_mq.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None

I don't think it's related to my changes since I did not edit aws_mq.py. Any suggestions on how to clear this up?

Add tag support to ec2_placement_group
c98cbbb 
Allows users to optionally create EC2 placement groups with tags.
Extend integration suite with additional test cases.
@harisokanovic harisokanovic force-pushed the dev/harisokn/pg-tags branch from 86e3163 to c98cbbb Compare July 29, 2024 15:38
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/269c4e8208664695abcd24ac132514d5

✔️ ansible-galaxy-importer SUCCESS in 3m 18s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 32s
✔️ ansible-test-splitter SUCCESS in 4m 24s
✔️ integration-community.aws-1 SUCCESS in 5m 34s
Skipped 21 jobs

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Aug 1, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0dc9b23c9add47919c8876fe2c90391e

❌ ansible-galaxy-importer FAILURE in 4m 49s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 30s
✔️ ansible-test-splitter SUCCESS in 4m 14s
✔️ integration-community.aws-1 SUCCESS in 7m 24s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c235bd3 into ansible-collections:main Aug 1, 2024
38 checks passed
@patchback Patchback
Copy link

patchback bot commented Aug 1, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/c235bd33fd7676aabf71ff928fb3d59d96c9f157/pr-2081

Backported as #2132

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 1, 2024
@harisokanovic @patchback
Add tag support to ec2_placement_group (#2081)
f7db64b 
SUMMARY
Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.
ISSUE TYPE

Feature Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Haris Okanovic <[email protected]>
Reviewed-by: Alina Buzachis
(cherry picked from commit c235bd3)
@patchback patchback bot mentioned this pull request Aug 1, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 1, 2024
@patchback
Add tag support to ec2_placement_group (#2081) (#2132)
880d453 
This is a backport of PR #2081 as merged into main (c235bd3).
SUMMARY
Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.
ISSUE TYPE

Feature Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@markuman markuman markuman approved these changes

@tremble tremble Awaiting requested review from tremble

Assignees
No one assigned
Labels
backport-8 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harisokanovic @markuman @tremble @alinabuzachis