Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to enable multicast on transit gateway #2063

Merged
merged 27 commits into from
Jul 2, 2024

Conversation

cschimid
Copy link
Contributor

SUMMARY

Need to enable multicast while creating transit gateway

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

transit_gateway

ADDITIONAL INFORMATION

@cschimid
Copy link
Contributor Author

I have successfully tested the module by creating a transit gateway with multicast enabled

Copy link

github-actions bot commented Mar 28, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ae11f6478f7546019fc2556b324ffabb

✔️ ansible-galaxy-importer SUCCESS in 4m 51s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 53s
✔️ ansible-test-splitter SUCCESS in 6m 14s
✔️ integration-community.aws-1 SUCCESS in 27m 15s
✔️ integration-community.aws-2 SUCCESS in 10m 50s
Skipped 20 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c67c7990e1ee4d23a5d30c3ad87db63a

✔️ ansible-galaxy-importer SUCCESS in 6m 18s (non-voting)
✔️ build-ansible-collection SUCCESS in 17m 52s
✔️ ansible-test-splitter SUCCESS in 7m 13s
✔️ integration-community.aws-1 SUCCESS in 30m 03s
✔️ integration-community.aws-2 SUCCESS in 9m 23s
Skipped 20 jobs

Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cschimid Thank you for taking time to work on this feature. Can you please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment and an integration test for this new feature? Thanks.

CHANGELOG.rst Outdated Show resolved Hide resolved
plugins/modules/ec2_transit_gateway.py Show resolved Hide resolved
plugins/modules/ec2_transit_gateway.py Show resolved Hide resolved
plugins/modules/ec2_transit_gateway_info.py Show resolved Hide resolved
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/76624bdbdcf54d9b944e74aee08001de

✔️ ansible-galaxy-importer SUCCESS in 4m 21s (non-voting)
✔️ build-ansible-collection SUCCESS in 18m 03s
✔️ ansible-test-splitter SUCCESS in 5m 21s
✔️ integration-community.aws-1 SUCCESS in 33m 39s
✔️ integration-community.aws-2 SUCCESS in 11m 31s
Skipped 20 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/99744ca9f84e44419a8933938e0040d0

✔️ ansible-galaxy-importer SUCCESS in 4m 28s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 24s
✔️ ansible-test-splitter SUCCESS in 5m 44s
✔️ integration-community.aws-1 SUCCESS in 34m 01s
integration-community.aws-2 FAILURE in 11m 22s
Skipped 20 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/851a7033219a47ee9316b0431af09c11

ansible-galaxy-importer FAILURE in 5m 54s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 10s
✔️ ansible-test-splitter SUCCESS in 5m 43s
✔️ integration-community.aws-1 SUCCESS in 27m 26s
integration-community.aws-2 FAILURE in 6m 26s
Skipped 20 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/37a2613486c042289bbd3eefda501e7c

ansible-galaxy-importer FAILURE in 5m 28s (non-voting)
✔️ build-ansible-collection SUCCESS in 23m 40s
✔️ ansible-test-splitter SUCCESS in 9m 11s
✔️ integration-community.aws-1 SUCCESS in 49m 15s
integration-community.aws-2 FAILURE in 10m 25s
Skipped 20 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5604a4ba5abb491cbd231811f3758790

ansible-galaxy-importer FAILURE in 5m 32s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 31s
✔️ ansible-test-splitter SUCCESS in 5m 26s
✔️ integration-community.aws-1 SUCCESS in 28m 21s
integration-community.aws-2 FAILURE in 16m 52s
Skipped 20 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/50f6a8f496f84710afc9eae2123409b3

ansible-galaxy-importer FAILURE in 5m 27s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 02s
✔️ ansible-test-splitter SUCCESS in 5m 21s
✔️ integration-community.aws-1 SUCCESS in 28m 02s
✔️ integration-community.aws-2 SUCCESS in 11m 21s
Skipped 20 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/726f0991ca514cb0b720d527c05f748a

✔️ ansible-galaxy-importer SUCCESS in 4m 58s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 30s
✔️ ansible-test-splitter SUCCESS in 7m 15s
✔️ integration-community.aws-1 SUCCESS in 28m 14s
✔️ integration-community.aws-2 SUCCESS in 11m 02s
Skipped 20 jobs

CHANGELOG.rst Outdated
@@ -4,29 +4,6 @@ community.aws Release Notes

.. contents:: Topics

v7.2.0
Copy link
Contributor

@alinabuzachis alinabuzachis Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cschimid You should restore this part.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a7b6efacb8f24d37a862a9ac01412874

ansible-galaxy-importer FAILURE in 5m 23s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 09s
✔️ ansible-test-splitter SUCCESS in 5m 39s
✔️ integration-community.aws-1 SUCCESS in 28m 23s
✔️ integration-community.aws-2 SUCCESS in 12m 07s
Skipped 20 jobs

plugins/modules/ec2_transit_gateway.py Outdated Show resolved Hide resolved
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 2, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/59b2139a051f4dbdb10df9942ce6e765

ansible-galaxy-importer FAILURE in 4m 37s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 36s
✔️ ansible-test-splitter SUCCESS in 5m 02s
✔️ integration-community.aws-1 SUCCESS in 26m 40s
✔️ integration-community.aws-2 SUCCESS in 8m 43s
Skipped 20 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4752c05 into ansible-collections:main Jul 2, 2024
36 of 67 checks passed
Copy link

patchback bot commented Jul 2, 2024

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/4752c05c56076e1b904d7ee4dfd6c350601da0af/pr-2063

Backported as #2119

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 2, 2024
SUMMARY

Need to enable multicast while creating transit gateway

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

transit_gateway
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: Carlos Schimidt
Reviewed-by: Mark Chappell
(cherry picked from commit 4752c05)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 2, 2024
This is a backport of PR #2063 as merged into main (4752c05).
SUMMARY

Need to enable multicast while creating transit gateway

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

transit_gateway
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants