-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to enable multicast on transit gateway #2063
Add support to enable multicast on transit gateway #2063
Conversation
I have successfully tested the module by creating a transit gateway with multicast enabled |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 51s (non-voting) |
Correction on doc section for multicast option
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 6m 18s (non-voting) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cschimid Thank you for taking time to work on this feature. Can you please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment and an integration test for this new feature? Thanks.
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 21s (non-voting) |
Co-authored-by: Alina Buzachis <[email protected]>
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 28s (non-voting) |
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 54s (non-voting) |
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 28s (non-voting) |
Co-authored-by: Alina Buzachis <[email protected]>
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 32s (non-voting) |
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 27s (non-voting) |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 58s (non-voting) |
CHANGELOG.rst
Outdated
@@ -4,29 +4,6 @@ community.aws Release Notes | |||
|
|||
.. contents:: Topics | |||
|
|||
v7.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cschimid You should restore this part.
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 23s (non-voting) |
Build succeeded (gate pipeline). ❌ ansible-galaxy-importer FAILURE in 4m 37s (non-voting) |
4752c05
into
ansible-collections:main
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #2119 🤖 @patchback |
SUMMARY Need to enable multicast while creating transit gateway ISSUE TYPE Feature Pull Request COMPONENT NAME transit_gateway ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: Carlos Schimidt Reviewed-by: Mark Chappell (cherry picked from commit 4752c05)
SUMMARY
Need to enable multicast while creating transit gateway
ISSUE TYPE
COMPONENT NAME
transit_gateway
ADDITIONAL INFORMATION