Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unsafe asserts #2013

Merged
merged 8 commits into from
Dec 1, 2023
Merged

fix unsafe asserts #2013

merged 8 commits into from
Dec 1, 2023

Conversation

markuman
Copy link
Member

@markuman markuman commented Dec 1, 2023

SUMMARY

Closes #2012

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

integrationtests

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9242aed4655e47cc8d8f7dd9f40058ee

✔️ ansible-galaxy-importer SUCCESS in 4m 26s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 04s
✔️ ansible-test-splitter SUCCESS in 5m 21s
✔️ integration-community.aws-1 SUCCESS in 22m 45s
❌ integration-community.aws-2 FAILURE in 26m 14s
❌ integration-community.aws-3 FAILURE in 10m 04s
✔️ integration-community.aws-4 SUCCESS in 20m 24s
✔️ integration-community.aws-5 SUCCESS in 13m 37s
✔️ integration-community.aws-6 SUCCESS in 10m 12s
✔️ integration-community.aws-7 SUCCESS in 7m 58s
✔️ integration-community.aws-8 SUCCESS in 8m 39s
❌ integration-community.aws-9 FAILURE in 11m 38s
✔️ integration-community.aws-10 SUCCESS in 8m 20s
Skipped 12 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1e9d5358e7ca41368f0647674502b776

❌ ansible-galaxy-importer FAILURE in 4m 54s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 03s
✔️ ansible-test-splitter SUCCESS in 5m 47s
✔️ integration-community.aws-1 SUCCESS in 23m 05s
✔️ integration-community.aws-2 SUCCESS in 51m 34s
✔️ integration-community.aws-3 SUCCESS in 20m 53s
✔️ integration-community.aws-4 SUCCESS in 18m 29s
✔️ integration-community.aws-5 SUCCESS in 18m 04s
✔️ integration-community.aws-6 SUCCESS in 14m 40s
✔️ integration-community.aws-7 SUCCESS in 20m 47s
✔️ integration-community.aws-8 SUCCESS in 7m 39s
✔️ integration-community.aws-9 SUCCESS in 14m 53s
✔️ integration-community.aws-10 SUCCESS in 21m 43s
✔️ integration-community.aws-11 SUCCESS in 9m 25s
✔️ integration-community.aws-12 SUCCESS in 10m 25s
✔️ integration-community.aws-13 SUCCESS in 15m 49s
✔️ integration-community.aws-14 SUCCESS in 11m 16s
Skipped 8 jobs

@markuman markuman changed the title [WIP] fix unsafe asserts fix unsafe asserts Dec 1, 2023
@markuman markuman added backport-6 PR should be backported to the stable-6 branch backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory) labels Dec 1, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/d9fc03a339f949f5869fb26b229ae7f9

✔️ ansible-galaxy-importer SUCCESS in 4m 02s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 31s
✔️ ansible-test-splitter SUCCESS in 5m 43s
✔️ integration-community.aws-1 SUCCESS in 25m 21s
❌ integration-community.aws-2 RETRY_LIMIT in 7m 46s
✔️ integration-community.aws-3 SUCCESS in 26m 50s
✔️ integration-community.aws-4 SUCCESS in 17m 55s
✔️ integration-community.aws-5 SUCCESS in 17m 14s
✔️ integration-community.aws-6 SUCCESS in 13m 23s
✔️ integration-community.aws-7 SUCCESS in 18m 50s
✔️ integration-community.aws-8 SUCCESS in 6m 14s
✔️ integration-community.aws-9 SUCCESS in 14m 23s
❌ integration-community.aws-10 RETRY_LIMIT in 6m 58s
✔️ integration-community.aws-11 SUCCESS in 9m 18s
✔️ integration-community.aws-12 SUCCESS in 13m 11s
✔️ integration-community.aws-13 SUCCESS in 14m 41s
✔️ integration-community.aws-14 SUCCESS in 11m 40s
Skipped 8 jobs

@markuman
Copy link
Member Author

markuman commented Dec 1, 2023

regate

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/9a41c345b862430f9abcae67cce40189

✔️ ansible-galaxy-importer SUCCESS in 4m 17s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 25s
✔️ ansible-test-splitter SUCCESS in 5m 08s
✔️ integration-community.aws-1 SUCCESS in 22m 26s
✔️ integration-community.aws-2 SUCCESS in 37m 24s
✔️ integration-community.aws-3 SUCCESS in 21m 49s
✔️ integration-community.aws-4 SUCCESS in 17m 42s
✔️ integration-community.aws-5 SUCCESS in 17m 48s
✔️ integration-community.aws-6 SUCCESS in 13m 38s
✔️ integration-community.aws-7 SUCCESS in 19m 13s
✔️ integration-community.aws-8 SUCCESS in 8m 06s
✔️ integration-community.aws-9 SUCCESS in 20m 39s
✔️ integration-community.aws-10 SUCCESS in 24m 08s
✔️ integration-community.aws-11 SUCCESS in 10m 45s
✔️ integration-community.aws-12 SUCCESS in 11m 45s
✔️ integration-community.aws-13 SUCCESS in 15m 39s
✔️ integration-community.aws-14 SUCCESS in 10m 57s
Skipped 8 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4bdcecd into ansible-collections:main Dec 1, 2023
105 of 106 checks passed
@patchback Patchback
Copy link

patchback bot commented Dec 1, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/4bdcecda3d37e1ccd4d568ec641b59d0a745bbca/pr-2013

Backported as #2014

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 1, 2023
@markuman @patchback
fix unsafe asserts (#2013)
ee441a5 
fix unsafe asserts

SUMMARY
Closes #2012
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
integrationtests

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
(cherry picked from commit 4bdcecd)
@patchback patchback bot mentioned this pull request Dec 1, 2023
Merged
@patchback Patchback
Copy link

patchback bot commented Dec 1, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/4bdcecda3d37e1ccd4d568ec641b59d0a745bbca/pr-2013

Backported as #2015

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 1, 2023
@markuman @patchback
fix unsafe asserts (#2013)
e5c79af 
fix unsafe asserts

SUMMARY
Closes #2012
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
integrationtests

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
(cherry picked from commit 4bdcecd)
@patchback patchback bot mentioned this pull request Dec 1, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Dec 1, 2023
@patchback
fix unsafe asserts (#2013) (#2014)
2f23de1 
[PR #2013/4bdcecda backport][stable-6] fix unsafe asserts

This is a backport of PR #2013 as merged into main (4bdcecd).
SUMMARY
Closes #2012
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME
integrationtests

Reviewed-by: Markus Bergholz <[email protected]>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Dec 4, 2023
@patchback
fix unsafe asserts (#2013) (#2015)
155a2cf 
[PR #2013/4bdcecda backport][stable-7] fix unsafe asserts

This is a backport of PR #2013 as merged into main (4bdcecd).
SUMMARY
Closes #2012
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME
integrationtests

Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@tremble tremble tremble approved these changes

@mandar242 mandar242 Awaiting requested review from mandar242

@jillr jillr Awaiting requested review from jillr

@abikouo abikouo Awaiting requested review from abikouo

Assignees
No one assigned
Labels
backport-6 PR should be backported to the stable-6 branch backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration tests need to be updated to avoid unsafe templating
3 participants
@markuman @tremble @alinabuzachis