feat: add wait and wait_timeout to mq_broker; closes #1879 #1888
Conversation
ansibullbot
added
community_review
feature
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 41s (non-voting) |
|
@alinabuzachis @markuman anything else needed here? |
alialkhalidi
force-pushed
the
mq_broker_wait__1
branch
from
d7864fe to
b36f81f
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 29s (non-voting) |
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 52s (non-voting) |
|
ready_for_review |
|
recheck |
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 52s (non-voting) |
|
@alinabuzachis @tremble rebased. can we finish this? |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 10m 30s (non-voting) |
|
@alinabuzachis @tremble @markuman. can we finish this? |
There was a problem hiding this comment.
@alialkhalidi Sorry for the late reply. Can you please update version_added to 7.1.0? Other than that, LGTM! Thank you for working on this.
…ons#1879 Signed-off-by: Ali AlKhalidi <[email protected]>
Signed-off-by: Ali AlKhalidi <[email protected]>
Signed-off-by: Ali AlKhalidi <[email protected]>
alialkhalidi
force-pushed
the
mq_broker_wait__1
branch
from
5bf7c53 to
1487b23
Compare
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 12s (non-voting) |
|
recheck |
|
@alinabuzachis those failing tests are expected? |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 43s (non-voting) |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 26s (non-voting) |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 17s (non-voting) |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 47s (non-voting) |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 41s (non-voting) |
softwarefactory-project-zuul
bot
merged commit f65eb5a
into
ansible-collections:main
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #2039 🤖 @patchback |
feat: add wait and wait_timeout to mq_broker; closes #1879 SUMMARY add wait and wait_timeout to wait for broker desired state. This will be used instead of polling for broker desired state though a separate module, broker_info. ISSUE TYPE Feature Pull Request COMPONENT NAME mq_broker ADDITIONAL INFORMATION wait: description: - Specifies whether the module waits for the desired C(state). type: bool wait_timeout: description: - How long to wait (in seconds) for the broker to reach the desired state. default: 900 type: int Reviewed-by: Alina Buzachis (cherry picked from commit f65eb5a)
…2039) [PR #1888/f65eb5a1 backport][stable-7] feat: add wait and wait_timeout to mq_broker; closes #1879 This is a backport of PR #1888 as merged into main (f65eb5a). SUMMARY add wait and wait_timeout to wait for broker desired state. This will be used instead of polling for broker desired state though a separate module, broker_info. ISSUE TYPE Feature Pull Request COMPONENT NAME mq_broker ADDITIONAL INFORMATION wait: description: - Specifies whether the module waits for the desired C(state). type: bool wait_timeout: description: - How long to wait (in seconds) for the broker to reach the desired state. default: 900 type: int Reviewed-by: Mark Chappell
SUMMARY
add wait and wait_timeout to wait for broker desired state. This will be used instead of polling for broker desired state though a separate module, broker_info.
ISSUE TYPE
COMPONENT NAME
mq_broker
ADDITIONAL INFORMATION