Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI test fixups - Ansible milestone update #1863

Merged
merged 1 commit into from
Jul 1, 2023
Merged

CI test fixups - Ansible milestone update #1863

merged 1 commit into from
Jul 1, 2023

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 1, 2023

SUMMARY

Fixups failures exposed by #1852

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

dynamodb
sts_assume_role

ADDITIONAL INFORMATION

@tremble tremble marked this pull request as ready for review July 1, 2023 14:14
tremble
tremble commented Jul 1, 2023
View reviewed changes
tests/integration/targets/sts_assume_role/tasks/main.yml
# ============================================================
- name: test with empty parameters
sts_assume_role:
role_arn:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ansible now rejects None if it's supposed to be a string (YAML returns a Nil for blank entries which aren't explicitly passed as an empty string).

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a10492544ec64e05a7c61e7b986e39d0

❌ ansible-galaxy-importer FAILURE in 4m 03s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 15s
✔️ ansible-test-splitter SUCCESS in 5m 06s
✔️ integration-community.aws-1 SUCCESS in 37m 43s
✔️ integration-community.aws-2 SUCCESS in 6m 41s
Skipped 20 jobs

@tremble tremble added mergeit Merge the PR (SoftwareFactory) backport-5 PR should be backported to the stable-5 branch backport-6 PR should be backported to the stable-6 branch labels Jul 1, 2023
@tremble tremble mentioned this pull request Jul 1, 2023
Merged
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/1ffb4f5f08d04a378893f2b684c54b37

❌ ansible-galaxy-importer FAILURE in 4m 43s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 32s
✔️ ansible-test-splitter SUCCESS in 5m 08s
✔️ integration-community.aws-1 SUCCESS in 59m 56s
✔️ integration-community.aws-2 SUCCESS in 6m 43s
Skipped 20 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7f05515 into ansible-collections:main Jul 1, 2023
@patchback
Copy link

patchback bot commented Jul 1, 2023 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/7f05515ce1dac9f33b1303386d62dc3531f402e8/pr-1863

Backported as #1864

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 1, 2023
@tremble @patchback
CI test fixups - Ansible milestone update (#1863)
ce18e82 
CI test fixups - Ansible milestone update

SUMMARY
Fixups failures exposed by #1852
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
dynamodb
sts_assume_role
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
(cherry picked from commit 7f05515)
@patchback patchback bot mentioned this pull request Jul 1, 2023
Merged
@patchback
Copy link

patchback bot commented Jul 1, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/7f05515ce1dac9f33b1303386d62dc3531f402e8/pr-1863

Backported as #1865

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 1, 2023
@tremble @patchback
CI test fixups - Ansible milestone update (#1863)
a2951b4 
CI test fixups - Ansible milestone update

SUMMARY
Fixups failures exposed by #1852
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
dynamodb
sts_assume_role
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
(cherry picked from commit 7f05515)
@patchback patchback bot mentioned this pull request Jul 1, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 3, 2023
@patchback
CI test fixups - Ansible milestone update (#1863) (#1865)
28a2e5d 
[PR #1863/7f05515c backport][stable-6] CI test fixups - Ansible milestone update

This is a backport of PR #1863 as merged into main (7f05515).
SUMMARY
Fixups failures exposed by #1852
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
dynamodb
sts_assume_role
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 3, 2023
@patchback
CI test fixups - Ansible milestone update (#1863) (#1864)
59dd8c8 
[PR #1863/7f05515c backport][stable-5] CI test fixups - Ansible milestone update

This is a backport of PR #1863 as merged into main (7f05515).
SUMMARY
Fixups failures exposed by #1852
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
dynamodb
sts_assume_role
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
@tremble tremble deleted the tests/ansible-core/20230701 branch September 29, 2023 08:29
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @mandar242
CI test fixups - Ansible milestone update (ansible-collections#1863)
663d538 
CI test fixups - Ansible milestone update

SUMMARY
Fixups failures exposed by ansible-collections#1852
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
dynamodb
sts_assume_role
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@7f05515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
backport-5 PR should be backported to the stable-5 branch backport-6 PR should be backported to the stable-6 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremble @alinabuzachis