Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1822/dbf6362d backport][stable-6] cloudfront_distribution: no longer crashes when waiting for completion of creation #1835

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 1, 2023

This is a backport of PR #1822 as merged into main (dbf6362).

SUMMARY

Fixes #255

Here we were referring to the ["Id"] member of a queried distribution, but there is level of embedding missing: ["Distribution"]["Id"]

(Just how it's used here )

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloudfront_distribution

…n of creation (#1822)

cloudfront_distribution: no longer crashes when waiting for completion of creation

SUMMARY
Fixes #255
Here we were referring to the ["Id"] member of a queried distribution, but there is level of embedding missing: ["Distribution"]["Id"]
(Just how it's used here )
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudfront_distribution

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis
(cherry picked from commit dbf6362)
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/131a4512b3964191a6a37f100f4df5d3

ansible-galaxy-importer FAILURE in 3m 58s
✔️ build-ansible-collection SUCCESS in 13m 44s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 44s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 46s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 57s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 01s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 23s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 10m 58s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 40s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 10m 09s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 7m 39s
✔️ ansible-test-changelog SUCCESS in 4m 43s
✔️ ansible-test-splitter SUCCESS in 5m 28s
✔️ integration-community.aws-1 SUCCESS in 24m 00s
Skipped 21 jobs

@markuman
Copy link
Member

markuman commented Jun 1, 2023

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/492776410cdb45f682c0f7c839d9dcf1

✔️ ansible-galaxy-importer SUCCESS in 3m 53s
✔️ build-ansible-collection SUCCESS in 14m 12s
ansible-test-sanity-docker-devel POST_FAILURE in 13m 56s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 00s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 13m 15s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 16s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 13m 59s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 07s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 36s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 04s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 52s
✔️ ansible-test-changelog SUCCESS in 5m 20s
✔️ ansible-test-splitter SUCCESS in 6m 04s
✔️ integration-community.aws-1 SUCCESS in 24m 53s
Skipped 21 jobs

@markuman
Copy link
Member

markuman commented Jun 1, 2023

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a2c86ff3d87b435d9e3a3894ffc7ed76

ansible-galaxy-importer FAILURE in 4m 08s
✔️ build-ansible-collection SUCCESS in 12m 48s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 57s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 31s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 29s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 05s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 51s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 14s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 42s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 17s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 31s
✔️ ansible-test-changelog SUCCESS in 4m 29s
✔️ ansible-test-splitter SUCCESS in 4m 57s
✔️ integration-community.aws-1 SUCCESS in 32m 44s
Skipped 21 jobs

@alinabuzachis
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6d0e90df57a24c538f716591c64a8eaf

✔️ ansible-galaxy-importer SUCCESS in 5m 18s
✔️ build-ansible-collection SUCCESS in 13m 27s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 59s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 34s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 13m 45s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 13m 57s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 13m 48s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 43s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 58s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 58s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 36s
✔️ ansible-test-changelog SUCCESS in 4m 46s
✔️ ansible-test-splitter SUCCESS in 4m 53s
✔️ integration-community.aws-1 SUCCESS in 21m 42s
Skipped 21 jobs

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Jun 8, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/645e7098691b416a8f3ba51128c205c9

✔️ ansible-galaxy-importer SUCCESS in 4m 30s
✔️ build-ansible-collection SUCCESS in 12m 52s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 59s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 38s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 47s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 56s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 12m 37s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 29s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 05s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 04s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 12s
✔️ ansible-test-changelog SUCCESS in 4m 50s
✔️ ansible-test-splitter SUCCESS in 5m 17s
✔️ integration-community.aws-1 SUCCESS in 20m 05s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ef9bd18 into stable-6 Jun 8, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-6/dbf6362d642ab504e9b96981ef841dd40ad5b5ab/pr-1822 branch June 8, 2023 14:42
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants