Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk migration to Python 3.6 f-strings #1810

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 7, 2023

SUMMARY

We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup

A combination of

  • black --preview
  • flynt
  • some manual cleanup
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/
tests/

ADDITIONAL INFORMATION

@tremble tremble requested review from markuman and alinabuzachis May 7, 2023 11:32
@tremble tremble marked this pull request as ready for review May 7, 2023 11:41
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/95b19aa2f0af4216bb294ad702e26b10

ansible-galaxy-importer FAILURE in 3m 43s
✔️ build-ansible-collection SUCCESS in 13m 04s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 31s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 47s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 54s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 00s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 11s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 58s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 47s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 53s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 47s
✔️ ansible-test-changelog SUCCESS in 4m 23s
✔️ ansible-test-splitter SUCCESS in 4m 53s
✔️ integration-community.aws-1 SUCCESS in 30m 09s
✔️ integration-community.aws-2 SUCCESS in 21m 08s
✔️ integration-community.aws-3 SUCCESS in 41m 04s
✔️ integration-community.aws-4 SUCCESS in 48m 26s
✔️ integration-community.aws-5 SUCCESS in 5m 59s
✔️ integration-community.aws-6 SUCCESS in 21m 37s
✔️ integration-community.aws-7 SUCCESS in 32m 32s
✔️ integration-community.aws-8 SUCCESS in 19m 22s
✔️ integration-community.aws-9 SUCCESS in 40m 27s
✔️ integration-community.aws-10 SUCCESS in 21m 24s
✔️ integration-community.aws-11 SUCCESS in 14m 00s
✔️ integration-community.aws-12 SUCCESS in 11m 45s
✔️ integration-community.aws-13 SUCCESS in 18m 20s
✔️ integration-community.aws-14 SUCCESS in 23m 41s
✔️ integration-community.aws-15 SUCCESS in 30m 07s
✔️ integration-community.aws-16 SUCCESS in 8m 53s
✔️ integration-community.aws-17 SUCCESS in 15m 10s
✔️ integration-community.aws-18 SUCCESS in 8m 45s
Skipped 4 jobs

@alinabuzachis
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c001c5c0baaa44319585a7893f8a547e

ansible-galaxy-importer FAILURE in 3m 46s
✔️ build-ansible-collection SUCCESS in 13m 28s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 27s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 22s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 42s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 36s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 49s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 14s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 29s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 27s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 28s
✔️ ansible-test-changelog SUCCESS in 4m 28s
✔️ ansible-test-splitter SUCCESS in 5m 00s
✔️ integration-community.aws-1 SUCCESS in 32m 28s
✔️ integration-community.aws-2 SUCCESS in 21m 12s
✔️ integration-community.aws-3 SUCCESS in 36m 06s
✔️ integration-community.aws-4 SUCCESS in 43m 32s
✔️ integration-community.aws-5 SUCCESS in 6m 05s
✔️ integration-community.aws-6 SUCCESS in 19m 42s
✔️ integration-community.aws-7 SUCCESS in 28m 31s
✔️ integration-community.aws-8 SUCCESS in 21m 18s
✔️ integration-community.aws-9 SUCCESS in 38m 35s
✔️ integration-community.aws-10 SUCCESS in 28m 00s
integration-community.aws-11 RETRY_LIMIT in 1m 32s
✔️ integration-community.aws-12 SUCCESS in 11m 04s
✔️ integration-community.aws-13 SUCCESS in 21m 10s
✔️ integration-community.aws-14 SUCCESS in 22m 16s
✔️ integration-community.aws-15 SUCCESS in 29m 10s
✔️ integration-community.aws-16 SUCCESS in 10m 41s
✔️ integration-community.aws-17 SUCCESS in 16m 35s
integration-community.aws-18 RETRY_LIMIT in 1m 32s
Skipped 4 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 8, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/62ff9bdf4afd42dfb183daea600323df

✔️ ansible-galaxy-importer SUCCESS in 3m 46s
✔️ build-ansible-collection SUCCESS in 13m 09s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 52s (non-voting)
ansible-test-sanity-docker-milestone RETRY_LIMIT in 4m 32s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 43s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 57s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 11s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 09s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 31s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 12m 51s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 46s
✔️ ansible-test-changelog SUCCESS in 4m 29s
✔️ ansible-test-splitter SUCCESS in 5m 06s
✔️ integration-community.aws-1 SUCCESS in 29m 18s
✔️ integration-community.aws-2 SUCCESS in 22m 07s
✔️ integration-community.aws-3 SUCCESS in 34m 57s
✔️ integration-community.aws-4 SUCCESS in 40m 28s
✔️ integration-community.aws-5 SUCCESS in 6m 12s
✔️ integration-community.aws-6 SUCCESS in 25m 20s
✔️ integration-community.aws-7 SUCCESS in 28m 06s
integration-community.aws-8 RETRY_LIMIT in 1m 32s
✔️ integration-community.aws-9 SUCCESS in 37m 58s
✔️ integration-community.aws-10 SUCCESS in 24m 51s
✔️ integration-community.aws-11 SUCCESS in 13m 48s
✔️ integration-community.aws-12 SUCCESS in 11m 48s
✔️ integration-community.aws-13 SUCCESS in 21m 07s
✔️ integration-community.aws-14 SUCCESS in 23m 54s
✔️ integration-community.aws-15 SUCCESS in 28m 36s
✔️ integration-community.aws-16 SUCCESS in 9m 46s
✔️ integration-community.aws-17 SUCCESS in 16m 38s
✔️ integration-community.aws-18 SUCCESS in 9m 35s
Skipped 4 jobs

@tremble
Copy link
Contributor Author

tremble commented May 8, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/d792b6c0dadd4a47993af6ed23b741fe

✔️ ansible-galaxy-importer SUCCESS in 3m 39s
✔️ build-ansible-collection SUCCESS in 13m 16s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 02s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 07s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 25s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 24s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 26s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 04s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 33s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 44s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 54s
✔️ ansible-test-changelog SUCCESS in 4m 37s
✔️ ansible-test-splitter SUCCESS in 4m 58s
✔️ integration-community.aws-1 SUCCESS in 34m 14s
✔️ integration-community.aws-2 SUCCESS in 20m 49s
✔️ integration-community.aws-3 SUCCESS in 34m 52s
✔️ integration-community.aws-4 SUCCESS in 36m 10s
✔️ integration-community.aws-5 SUCCESS in 6m 32s
✔️ integration-community.aws-6 SUCCESS in 22m 41s
✔️ integration-community.aws-7 SUCCESS in 28m 46s
✔️ integration-community.aws-8 SUCCESS in 21m 40s
✔️ integration-community.aws-9 SUCCESS in 40m 11s
✔️ integration-community.aws-10 SUCCESS in 25m 21s
✔️ integration-community.aws-11 SUCCESS in 13m 15s
✔️ integration-community.aws-12 SUCCESS in 10m 23s
✔️ integration-community.aws-13 SUCCESS in 18m 49s
✔️ integration-community.aws-14 SUCCESS in 21m 46s
✔️ integration-community.aws-15 SUCCESS in 27m 32s
✔️ integration-community.aws-16 SUCCESS in 11m 17s
✔️ integration-community.aws-17 SUCCESS in 14m 58s
✔️ integration-community.aws-18 SUCCESS in 9m 44s
Skipped 4 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit de33821 into ansible-collections:main May 8, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@tremble tremble deleted the fstring/bulk branch September 29, 2023 08:28
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Bulk migration to Python 3.6 f-strings

SUMMARY
We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup
A combination of

black --preview
flynt
some manual cleanup

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/
tests/
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@de33821
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Bulk migration to Python 3.6 f-strings

SUMMARY
We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup
A combination of

black --preview
flynt
some manual cleanup

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/
tests/
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@de33821
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Bulk migration to Python 3.6 f-strings

SUMMARY
We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup
A combination of

black --preview
flynt
some manual cleanup

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/
tests/
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@de33821
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Bulk migration to Python 3.6 f-strings

SUMMARY
We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup
A combination of

black --preview
flynt
some manual cleanup

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/
tests/
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@de33821
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Bulk migration to Python 3.6 f-strings

SUMMARY
We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup
A combination of

black --preview
flynt
some manual cleanup

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/
tests/
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@de33821
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Bulk migration to Python 3.6 f-strings

SUMMARY
We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup
A combination of

black --preview
flynt
some manual cleanup

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/
tests/
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@de33821
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Bulk migration to Python 3.6 f-strings

SUMMARY
We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup
A combination of

black --preview
flynt
some manual cleanup

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/
tests/
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@de33821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants