Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/elbv2-tg: KeyError when getting ProtocolVersion #1800

Merged
merged 2 commits into from
May 5, 2023
Merged

fix/elbv2-tg: KeyError when getting ProtocolVersion #1800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e8a063
fix/elbv2-tg: KeyError when getting ProtocolVersion
mtulio May 2, 2023
bf4e43d
Formatting
tremble May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/1800-elb_target_group_property.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- elb_target_group - get ``ProtocolVersion`` key from ``target_group`` attributes only when exists (https://github.com/ansible-collections/community.aws/pull/1800).
2 changes: 1 addition & 1 deletion plugins/modules/elb_target_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ def create_or_update_target_group(connection, module):
# TODO: required and here?
if "Matcher" in params:
code_key = "HttpCode"
if target_group["ProtocolVersion"] == "GRPC":
if target_group.get("ProtocolVersion") == "GRPC":
code_key = "GrpcCode"
current_matcher_list = target_group["Matcher"][code_key].split(",")
requested_matcher_list = params["Matcher"][code_key].split(",")
Expand Down