Add sanity, linters, changelog, black and units workflows #1799
Conversation
alinabuzachis
force-pushed
the
github_action_linter_sanity
branch
2 times, most recently
from
1508748 to
0910bca
Compare
alinabuzachis
changed the title
alinabuzachis
force-pushed
the
github_action_linter_sanity
branch
from
0910bca to
5c2a8fc
Compare
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 55s |
.github/workflows/black.yml
Outdated
| @@ -0,0 +1,17 @@ | |||
| --- | |||
| name: black | |||
There was a problem hiding this comment.
The linters workflow will take care of the 'black' check. I do not think we need a separate workflow for black.
|
Should we change the amazon.aws version here to the one available in galaxy? I think this should resolve the failures we see in sanity and unit tests. I may be wrong ! |
alinabuzachis
force-pushed
the
github_action_linter_sanity
branch
2 times, most recently
from
c4c9656 to
9e794ba
Compare
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 56s |
Please don't! We should be pulling the amazon.aws collection from the relevant branches in git. If something's mangling versions again, then that's also behaviour that should be fixed. (Historically the network team kept ignoring galaxy.yml and overwriting the version in there which is horrible behaviour) |
alinabuzachis
force-pushed
the
github_action_linter_sanity
branch
from
9e794ba to
f8fed4a
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 19s |
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 42s |
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 51s |
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 12s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 20s |
|
#1815 should fix the unit test failures in Github Actions. |
|
Can you recheck after rebasing? The latest test-requirements file is not picked up. |
alinabuzachis
force-pushed
the
github_action_linter_sanity
branch
from
1ed843d to
8ebebdb
Compare
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
github_action_linter_sanity
branch
from
5e92cca to
e8df0e1
Compare
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
github_action_linter_sanity
branch
2 times, most recently
from
3a9291e to
160da9a
Compare
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
github_action_linter_sanity
branch
from
160da9a to
87bf695
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 02s |
Signed-off-by: Alina Buzachis <[email protected]>
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 34s |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 28s |
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 59s |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 32s |
|
regate |
|
regate |
…llections#1799) * Add sanity, linters, changelog and units workflows Signed-off-by: Alina Buzachis <[email protected]> * Delete black.yml Signed-off-by: Alina Buzachis <[email protected]> * Update references Signed-off-by: Alina Buzachis <[email protected]> * Remove linters job Signed-off-by: Alina Buzachis <[email protected]> * Add missing tox.ini file Signed-off-by: Alina Buzachis <[email protected]> * Apply black on plugins/modules/cloudfront_distribution.py Signed-off-by: Alina Buzachis <[email protected]> * Update tox.ini Signed-off-by: Alina Buzachis <[email protected]> * Fix units Signed-off-by: Alina Buzachis <[email protected]> --------- Signed-off-by: Alina Buzachis <[email protected]>
…llections#1799) * Add sanity, linters, changelog and units workflows Signed-off-by: Alina Buzachis <[email protected]> * Delete black.yml Signed-off-by: Alina Buzachis <[email protected]> * Update references Signed-off-by: Alina Buzachis <[email protected]> * Remove linters job Signed-off-by: Alina Buzachis <[email protected]> * Add missing tox.ini file Signed-off-by: Alina Buzachis <[email protected]> * Apply black on plugins/modules/cloudfront_distribution.py Signed-off-by: Alina Buzachis <[email protected]> * Update tox.ini Signed-off-by: Alina Buzachis <[email protected]> * Fix units Signed-off-by: Alina Buzachis <[email protected]> --------- Signed-off-by: Alina Buzachis <[email protected]>
…llections#1799) * Add sanity, linters, changelog and units workflows Signed-off-by: Alina Buzachis <[email protected]> * Delete black.yml Signed-off-by: Alina Buzachis <[email protected]> * Update references Signed-off-by: Alina Buzachis <[email protected]> * Remove linters job Signed-off-by: Alina Buzachis <[email protected]> * Add missing tox.ini file Signed-off-by: Alina Buzachis <[email protected]> * Apply black on plugins/modules/cloudfront_distribution.py Signed-off-by: Alina Buzachis <[email protected]> * Update tox.ini Signed-off-by: Alina Buzachis <[email protected]> * Fix units Signed-off-by: Alina Buzachis <[email protected]> --------- Signed-off-by: Alina Buzachis <[email protected]>
…llections#1799) * Add sanity, linters, changelog and units workflows Signed-off-by: Alina Buzachis <[email protected]> * Delete black.yml Signed-off-by: Alina Buzachis <[email protected]> * Update references Signed-off-by: Alina Buzachis <[email protected]> * Remove linters job Signed-off-by: Alina Buzachis <[email protected]> * Add missing tox.ini file Signed-off-by: Alina Buzachis <[email protected]> * Apply black on plugins/modules/cloudfront_distribution.py Signed-off-by: Alina Buzachis <[email protected]> * Update tox.ini Signed-off-by: Alina Buzachis <[email protected]> * Fix units Signed-off-by: Alina Buzachis <[email protected]> --------- Signed-off-by: Alina Buzachis <[email protected]>
…llections#1799) * Add sanity, linters, changelog and units workflows Signed-off-by: Alina Buzachis <[email protected]> * Delete black.yml Signed-off-by: Alina Buzachis <[email protected]> * Update references Signed-off-by: Alina Buzachis <[email protected]> * Remove linters job Signed-off-by: Alina Buzachis <[email protected]> * Add missing tox.ini file Signed-off-by: Alina Buzachis <[email protected]> * Apply black on plugins/modules/cloudfront_distribution.py Signed-off-by: Alina Buzachis <[email protected]> * Update tox.ini Signed-off-by: Alina Buzachis <[email protected]> * Fix units Signed-off-by: Alina Buzachis <[email protected]> --------- Signed-off-by: Alina Buzachis <[email protected]>
* Add sanity, linters, changelog, black and units workflows (#1799) * Add sanity, linters, changelog and units workflows Signed-off-by: Alina Buzachis <[email protected]> * Delete black.yml Signed-off-by: Alina Buzachis <[email protected]> * Update references Signed-off-by: Alina Buzachis <[email protected]> * Remove linters job Signed-off-by: Alina Buzachis <[email protected]> * Add missing tox.ini file Signed-off-by: Alina Buzachis <[email protected]> * Apply black on plugins/modules/cloudfront_distribution.py Signed-off-by: Alina Buzachis <[email protected]> * Update tox.ini Signed-off-by: Alina Buzachis <[email protected]> * Fix units Signed-off-by: Alina Buzachis <[email protected]> --------- Signed-off-by: Alina Buzachis <[email protected]> * Fix 'unnecessary-comprehension: Unnecessary use of a comprehension, use list(dist['Aliases'].get('Items', [])) instead.' Signed-off-by: Alina Buzachis <[email protected]> * Increase amazon.aws collection version in galaxy.yml Signed-off-by: Alina Buzachis <[email protected]> * Revert Signed-off-by: Alina Buzachis <[email protected]> * Use RetryingBotoClientWrapper rather than _RetryingBotoClientWrapper Signed-off-by: Alina Buzachis <[email protected]> * Fix sanity ignore files Signed-off-by: Alina Buzachis <[email protected]> * Add galaxy-importer Signed-off-by: Alina Buzachis <[email protected]> * Add linters to tox Signed-off-by: Alina Buzachis <[email protected]> * Add W504 to ignore Signed-off-by: Alina Buzachis <[email protected]> --------- Signed-off-by: Alina Buzachis <[email protected]>
SUMMARY
Add sanity, linters, changelog, black and units workflows
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION