Big Black PR #1784
Merged
Big Black PR #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done |
markuman
approved these changes
Apr 24, 2023
alinabuzachis
approved these changes
Apr 24, 2023
tremble
added
mergeit
This comment was marked as resolved.
This comment was marked as resolved.
|
regate |
|
regate |
|
regate |
|
regate |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Merged
rmahroua
pushed a commit
to rmahroua/community.aws
that referenced
this pull request
May 4, 2023
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests
rmahroua
pushed a commit
to rmahroua/community.aws
that referenced
this pull request
May 4, 2023
black - aws_ssm SUMMARY The aws_ssm integration tests are currently broken (ansible-collections#1793), apply the black changes ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION changes were approved as a part of ansible-collections#1784 but split because the tests were broken Reviewed-by: Alina Buzachis
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2c4575c
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2c4575c
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2c4575c
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2c4575c
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2c4575c
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2c4575c
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2c4575c
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2c4575c
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…e_s3_bucket_info Promote s3_bucket_info
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2c4575c
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2c4575c
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2c4575c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In preparation for 6.0.0 we agreed to mass apply the black formatter to our code base.
Hopefully we're only a couple of weeks out now, and we're much more on top of our PRs than we used to be. This is the big PR...
ISSUE TYPE
COMPONENT NAME
plugins/
tests/
ADDITIONAL INFORMATION
There are two commits, the first "pre-tunes" a few things so that they're not exploded into lots of extra lines, or squashed into one line. The second is just the result of
black plugins/ tests/See also: #1798