Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eks_nodegroup - fixing remote access and added to integration tests #1781

Merged
merged 1 commit into from
Apr 20, 2023
Merged

eks_nodegroup - fixing remote access and added to integration tests #1781

merged 1 commit into from
Apr 20, 2023

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Apr 20, 2023 •
edited
Loading

SUMMARY

This was incorrectly merged directly into stable-5 rather than main.

Fixes #1771

Handling remote_access configuration the right way that boto understands it. Also included it to integration tests.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

eks_nodegroup

ADDITIONAL INFORMATION

This is pulling #1773 from stable-5 into main
Reviewed-by: Markus Bergholz
Reviewed-by: Thomas Bruckmann
Reviewed-by: Mark Chappell

@romulus-ai @tremble
eks_nodegroup - fixing remote access and added to integration tests (a…
644cd58 
…nsible-collections#1773)

eks_nodegroup - fixing remote access and added to integration tests

SUMMARY
Fixes ansible-collections#1771
Handling remote_access configuration the right way that boto understands it. Also included it to integration tests.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
eks_nodegroup

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Thomas Bruckmann
Reviewed-by: Mark Chappell
@tremble tremble requested a review from markuman April 20, 2023 07:28
@tremble tremble marked this pull request as ready for review April 20, 2023 07:28
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7bf87a58c79945aa9680db6a06e718d6

✔️ ansible-galaxy-importer SUCCESS in 3m 44s
✔️ build-ansible-collection SUCCESS in 13m 06s
✔️ ansible-test-sanity-docker-devel SUCCESS in 20m 28s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 20m 39s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 29m 41s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 37s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 27s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 25s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 47s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 28s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 7m 31s
✔️ ansible-test-changelog SUCCESS in 4m 21s
✔️ ansible-test-splitter SUCCESS in 5m 07s
✔️ integration-community.aws-1 SUCCESS in 30m 33s
Skipped 21 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 20, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/bf1a44166a064d1c8c509e2e2dd73ca8

❌ ansible-galaxy-importer FAILURE in 3m 43s
✔️ build-ansible-collection SUCCESS in 13m 13s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 58s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 05s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 32m 26s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 13m 12s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 12m 35s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 51s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 27s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 03s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 51s
✔️ ansible-test-changelog SUCCESS in 4m 20s
✔️ ansible-test-splitter SUCCESS in 4m 45s
✔️ integration-community.aws-1 SUCCESS in 23m 48s
Skipped 21 jobs

@tremble
Copy link
Contributor Author

tremble commented Apr 20, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/f8fd0260316f4b27840c36b517ddb091

✔️ ansible-galaxy-importer SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 13m 07s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 31s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 16s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 17m 45s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 19m 17s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 24s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 15s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 22s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 49s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 22s
✔️ ansible-test-changelog SUCCESS in 4m 31s
✔️ ansible-test-splitter SUCCESS in 4m 50s
❌ integration-community.aws-1 FAILURE in 22m 28s
Skipped 21 jobs

@tremble
Copy link
Contributor Author

tremble commented Apr 20, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/5db98e16744545c6b3c3d27152445259

✔️ ansible-galaxy-importer SUCCESS in 3m 55s
✔️ build-ansible-collection SUCCESS in 13m 11s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 22s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 25s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 59s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 15s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 41s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 53s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 01s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 52s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 27s
✔️ ansible-test-changelog SUCCESS in 4m 29s
✔️ ansible-test-splitter SUCCESS in 5m 04s
✔️ integration-community.aws-1 SUCCESS in 29m 09s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 0b8dfc5 into ansible-collections:main Apr 20, 2023
@tremble tremble deleted the port/main/1773 branch September 29, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuman markuman markuman approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eks_nodegroup module remote_access config not working as documented
3 participants
@tremble @markuman @romulus-ai