Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elasticache_info: ignore CacheClusterNotFound exeption during tag collect #1777

Merged
merged 2 commits into from
Apr 19, 2023
Merged

elasticache_info: ignore CacheClusterNotFound exeption during tag collect #1777

merged 2 commits into from
Apr 19, 2023

Conversation

goneri
Copy link
Member

@goneri goneri commented Apr 18, 2023

If we call get_elasticache_tags_with_backoff() on a cluster with an invalid
state (eg: deleting), AWS will trigger an CacheClusterNotFound.

With this change, elasticache_info will ignore the cluster and continue with
the next one.

@goneri
elasticache_info: ignore CacheClusterNotFound exeption during tag col…
c972ed7 
…lect

If we call `get_elasticache_tags_with_backoff()` on a cluster with an invalid
state (eg: deleting), AWS will trigger an `CacheClusterNotFound`.

With this change, `elasticache_info` will ignore the cluster and continue with
the next one.
@goneri goneri force-pushed the elasticache_info-ignore-CacheClusterNotFound-exeption-during-tag-collect_18928 branch from 50ac98f to c972ed7 Compare April 18, 2023 20:48
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e2feca98d27b4d049ec1824e83862758

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 12m 51s
✔️ ansible-test-sanity-docker-devel SUCCESS in 15m 01s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 53s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 18s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 00s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 48s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 46s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 26s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 26s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 28s
✔️ ansible-test-changelog SUCCESS in 4m 42s
✔️ ansible-test-splitter SUCCESS in 5m 04s
✔️ integration-community.aws-1 SUCCESS in 8m 15s
Skipped 21 jobs

tremble
tremble approved these changes Apr 19, 2023
View reviewed changes
plugins/modules/elasticache_info.py Outdated Show resolved Hide resolved
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 19, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0cf526d7eacd4fa7b5db3f8a45cb0b01

✔️ ansible-galaxy-importer SUCCESS in 3m 39s
✔️ build-ansible-collection SUCCESS in 12m 42s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 02s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 54s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 18s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 05s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 00s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 24s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 04s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 57s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 16s
✔️ ansible-test-changelog SUCCESS in 4m 49s
✔️ ansible-test-splitter SUCCESS in 4m 53s
✔️ integration-community.aws-1 SUCCESS in 6m 44s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5461b2e into ansible-collections:main Apr 19, 2023
@tremble tremble added the backport-5 PR should be backported to the stable-5 branch label Apr 19, 2023
@patchback
Copy link

patchback bot commented Apr 19, 2023 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/5461b2e20e30487b1cf9b05ded18e91bc7fdd53c/pr-1777

Backported as #1778

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 19, 2023
@goneri @patchback
elasticache_info: ignore CacheClusterNotFound exeption during tag col…
bcbcb5f 
…lect (#1777)

elasticache_info: ignore CacheClusterNotFound exeption during tag collect

If we call get_elasticache_tags_with_backoff() on a cluster with an invalid
state (eg: deleting), AWS will trigger an CacheClusterNotFound.
With this change, elasticache_info will ignore the cluster and continue with
the next one.

Reviewed-by: Mark Chappell
(cherry picked from commit 5461b2e)
@patchback patchback bot mentioned this pull request Apr 19, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 19, 2023
@patchback
elasticache_info: ignore CacheClusterNotFound exeption during tag col…
0344815 
…lect (#1777) (#1778)

[PR #1777/5461b2e2 backport][stable-5] elasticache_info: ignore CacheClusterNotFound exeption during tag collect

This is a backport of PR #1777 as merged into main (5461b2e).
If we call get_elasticache_tags_with_backoff() on a cluster with an invalid
state (eg: deleting), AWS will trigger an CacheClusterNotFound.
With this change, elasticache_info will ignore the cluster and continue with
the next one.

Reviewed-by: Mark Chappell
@goneri
Copy link
Member Author

goneri commented Apr 19, 2023

Thank you @tremble :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
backport-5 PR should be backported to the stable-5 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goneri @tremble