elb_target_group: fix lost property AvailabilityZone #1767
Conversation
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 24s |
|
recheck |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 37s |
|
recheck |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 43s |
|
this is the broken task: https://github.com/ansible-collections/community.aws/blob/main/tests/integration/targets/elb_target/tasks/ec2_target.yml#L388-L396 I wonder if it is the same error that is also facing the ecs_cluster integration test - broken network setup. |
|
the
I guess the cloudinit will run into the same |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
next error |
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 12s |
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 48s |
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 48s |
|
recheck |
1 similar comment
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 09s |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 41s |
markuman
added
mergeit
|
regate |
|
recheck |
|
regate |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 20s |
|
recheck |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 45s |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1776 🤖 @patchback |
elb_target_group: fix lost property AvailabilityZone SUMMARY Closes #1736 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_target_group Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit d8362a0)
[PR #1767/d8362a0e backport][stable-5] elb_target_group: fix lost property AvailabilityZone This is a backport of PR #1767 as merged into main (d8362a0). SUMMARY Closes #1736 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_target_group Reviewed-by: Markus Bergholz <[email protected]>
… retries enabled (ansible-collections#1768) elb_application_lb_info - ensure queries for additional ALB data have retries enabled SUMMARY As per ansible-collections#1767 the queries to pull extra info about ALBs are hitting rate limits when there's a lot of ALBs. Unfortunately the initial list operation has limited server-side filtering capabilities (and we don't have consistent client side filtering implemented at this time). Ensure that all of the extra queries have retries with jittered backoff enabled. Additionally, drops a redundant describe_load_balancers call to retrieve the ip_address_type information. (added by ansible-collections#499) ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb_info ADDITIONAL INFORMATION I don't consider this a full fix for ansible-collections#1767 so I'm not using the "fixes". Reviewed-by: Alina Buzachis
…nsible-collections#1778) elb_application_lb_info - Add parameters to skip fetching some data Add include_attributes, include_listeners and include_listener_rules. SUMMARY Related to ansible-collections#1767. This PR adds parameters to the module which disable fetching certain data. They all default to true for backwards compatibility. In my tests disabling all 3 speeds it up by around 10x when fetching a lot (100+) ALBs. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_application_lb_info ADDITIONAL INFORMATION Please let me know if the coupling of include_listeners and include_listener_rules isn't desired. I can add checks to require include_listeners be true if include_listener_rules as an alternative (or something else?). Reviewed-by: Mark Chappell
SUMMARY
Closes #1736
ISSUE TYPE
COMPONENT NAME
elb_target_group