Add version_description to ec2_launch_template #1763

squirrel532 · 2023-03-29T18:44:40Z

SUMMARY

Add version_description to ec2_launch_template module, which allows user update the VersionDescription of a launch template.

Fix #1762

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_launch_template

ADDITIONAL INFORMATION

github-actions · 2023-03-29T18:55:11Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2023-03-29T19:10:27Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d2843cb7c796485aad544d23182d66c3

❌ ansible-galaxy-importer FAILURE in 4m 19s
✔️ build-ansible-collection SUCCESS in 12m 38s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 02s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 26s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 07s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 28s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 30s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 47s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 33s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 59s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 06s
❌ ansible-test-changelog FAILURE in 4m 26s
✔️ ansible-test-splitter SUCCESS in 4m 50s
✔️ integration-community.aws-1 SUCCESS in 6m 57s
Skipped 21 jobs

ansibullbot · 2023-04-01T17:45:10Z

cc @jillr @markuman @s-hertel @tremble
click here for bot help

softwarefactory-project-zuul · 2023-04-01T18:09:17Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/93613243853048f2922fdb8574348a3a

❌ ansible-galaxy-importer FAILURE in 4m 19s
✔️ build-ansible-collection SUCCESS in 13m 07s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 41s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 52s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 02s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 56s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 23s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 10s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 29s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 12s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 27s
✔️ ansible-test-changelog SUCCESS in 4m 25s
✔️ ansible-test-splitter SUCCESS in 4m 49s
✔️ integration-community.aws-1 SUCCESS in 6m 45s
Skipped 21 jobs

squirrel532 · 2023-04-01T18:40:08Z

@markuman I'm finished. Please review it.

softwarefactory-project-zuul · 2023-04-01T18:53:59Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/03a08c30de3040f9b87f8be892c5f26b

softwarefactory-project-zuul · 2023-04-02T06:19:55Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/559b50640fdc4e15a1a86398b344bd3d

❌ ansible-galaxy-importer FAILURE in 4m 14s
✔️ build-ansible-collection SUCCESS in 12m 30s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 29s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 49s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 49s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 52s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 08s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 59s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 34s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 16s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 17s
✔️ ansible-test-changelog SUCCESS in 4m 15s
✔️ ansible-test-splitter SUCCESS in 5m 00s
✔️ integration-community.aws-1 SUCCESS in 8m 18s
Skipped 21 jobs

plugins/modules/ec2_launch_template.py

changelogs/fragments/1763-ec2-launch-template-add-version-description.yml

…ription.yml

softwarefactory-project-zuul · 2023-04-03T08:14:52Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c128b110ecd04b839b0ea51a13c9d1b7

❌ ansible-galaxy-importer FAILURE in 4m 38s
✔️ build-ansible-collection SUCCESS in 13m 12s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 40s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 46s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 55s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 36s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 48s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 31s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 52s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 10s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 52s
✔️ ansible-test-changelog SUCCESS in 4m 49s
✔️ ansible-test-splitter SUCCESS in 5m 13s
✔️ integration-community.aws-1 SUCCESS in 6m 54s
Skipped 21 jobs

alinabuzachis · 2023-04-03T09:04:53Z

recheck

softwarefactory-project-zuul · 2023-04-03T09:30:55Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/241fad83c1874b3e9b307e70d064b652

markuman · 2023-04-03T14:34:16Z

@squirrel532 we need some darker formations.
can you also apply them please? https://github.com/ansible-collections/community.aws/actions/runs/4594116048/jobs/8112755969?pr=1763

softwarefactory-project-zuul · 2023-04-04T09:40:51Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a677e280c1814a88ba8e72733faadee0

✔️ ansible-galaxy-importer SUCCESS in 3m 57s
✔️ build-ansible-collection SUCCESS in 12m 58s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 07s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 06s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 17s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 05s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 48s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 24s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 26s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 02s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 7m 47s
✔️ ansible-test-changelog SUCCESS in 4m 20s
✔️ ansible-test-splitter SUCCESS in 4m 41s
✔️ integration-community.aws-1 SUCCESS in 6m 48s
Skipped 21 jobs

softwarefactory-project-zuul · 2023-04-12T07:45:12Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/d5de99e2630242999adcce6ac333bee2

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 13m 27s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 23s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 15m 09s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 34s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 14m 58s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 15m 02s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 16s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 42s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 53s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 08s
✔️ ansible-test-changelog SUCCESS in 4m 32s
✔️ ansible-test-splitter SUCCESS in 4m 49s
✔️ integration-community.aws-1 SUCCESS in 8m 09s
Skipped 21 jobs

patchback · 2023-04-12T07:45:17Z

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/3c3698d79ce5f56cefd24efe98cc49e6330f4c29/pr-1763

Backported as #1770

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Add version_description to ec2_launch_template SUMMARY Add version_description to ec2_launch_template module, which allows user update the VersionDescription of a launch template. Fix #1762 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_launch_template ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 3c3698d)

[PR #1763/3c3698d7 backport][stable-5] Add version_description to ec2_launch_template This is a backport of PR #1763 as merged into main (3c3698d). SUMMARY Add version_description to ec2_launch_template module, which allows user update the VersionDescription of a launch template. Fix #1762 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_launch_template ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]>

[7.0.0] Bump minimum botocore requirements SUMMARY In line with policy bump minimum botocore requirement to 1.29.0 (released Nov 2022) in preparation for release 7.0.0 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis

Add version_description to ec2_launch_template

4c7da02

Add changelogs

d704be3

ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Apr 1, 2023

Larry Huang added 2 commits April 2, 2023 02:27

Add test

36a2bbe

Compare version_description with previous version

aa05413

ansibullbot added integration tests/integration tests tests labels Apr 1, 2023

Fix VersionDescription not existed

6117d14

markuman reviewed Apr 3, 2023

View reviewed changes

plugins/modules/ec2_launch_template.py Outdated Show resolved Hide resolved

Update plugins/modules/ec2_launch_template.py

9e5278d

markuman added the backport-5 PR should be backported to the stable-5 branch label Apr 3, 2023

markuman added this to the 5.5.0 milestone Apr 3, 2023

ansibullbot removed the needs_triage label Apr 3, 2023

markuman reviewed Apr 3, 2023

View reviewed changes

changelogs/fragments/1763-ec2-launch-template-add-version-description.yml Outdated Show resolved Hide resolved

Update changelogs/fragments/1763-ec2-launch-template-add-version-desc…

3d937c8

…ription.yml

Lint code by darker

5cc56fe

markuman approved these changes Apr 4, 2023

View reviewed changes

markuman requested review from tremble and alinabuzachis April 4, 2023 17:59

markuman added the mergeit Merge the PR (SoftwareFactory) label Apr 12, 2023

softwarefactory-project-zuul bot merged commit 3c3698d into ansible-collections:main Apr 12, 2023

patchback bot mentioned this pull request Apr 12, 2023

[PR #1763/3c3698d7 backport][stable-5] Add version_description to ec2_launch_template #1770

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add version_description to ec2_launch_template #1763

Add version_description to ec2_launch_template #1763

squirrel532 commented Mar 29, 2023

github-actions bot commented Mar 29, 2023 •

edited

Loading

softwarefactory-project-zuul bot commented Mar 29, 2023

ansibullbot commented Apr 1, 2023

softwarefactory-project-zuul bot commented Apr 1, 2023

squirrel532 commented Apr 1, 2023

softwarefactory-project-zuul bot commented Apr 1, 2023

softwarefactory-project-zuul bot commented Apr 2, 2023

softwarefactory-project-zuul bot commented Apr 3, 2023

alinabuzachis commented Apr 3, 2023

softwarefactory-project-zuul bot commented Apr 3, 2023

markuman commented Apr 3, 2023

softwarefactory-project-zuul bot commented Apr 4, 2023

softwarefactory-project-zuul bot commented Apr 12, 2023

patchback bot commented Apr 12, 2023 •

edited

Loading

Add version_description to ec2_launch_template #1763

Add version_description to ec2_launch_template #1763

Conversation

squirrel532 commented Mar 29, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

github-actions bot commented Mar 29, 2023 • edited Loading

Docs Build 📝

softwarefactory-project-zuul bot commented Mar 29, 2023

ansibullbot commented Apr 1, 2023

softwarefactory-project-zuul bot commented Apr 1, 2023

squirrel532 commented Apr 1, 2023

softwarefactory-project-zuul bot commented Apr 1, 2023

softwarefactory-project-zuul bot commented Apr 2, 2023

softwarefactory-project-zuul bot commented Apr 3, 2023

alinabuzachis commented Apr 3, 2023

softwarefactory-project-zuul bot commented Apr 3, 2023

markuman commented Apr 3, 2023

softwarefactory-project-zuul bot commented Apr 4, 2023

softwarefactory-project-zuul bot commented Apr 12, 2023

patchback bot commented Apr 12, 2023 • edited Loading

Backport to stable-5: 💚 backport PR created

github-actions bot commented Mar 29, 2023 •

edited

Loading

patchback bot commented Apr 12, 2023 •

edited

Loading