Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sns: Add parameters for fifo topics #1733

Merged
merged 16 commits into from
Mar 14, 2023
Merged

sns: Add parameters for fifo topics #1733

merged 16 commits into from
Mar 14, 2023

Conversation

Pascal-Architrave
Copy link
Contributor

SUMMARY

Implements #1718. Adding message_group_id and message_deduplication_id to support publishing of messages to fifo topics.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sns

@github-actions
Copy link

github-actions bot commented Mar 2, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/35695f7402144c6ca06da8a0a5d3a268

✔️ ansible-galaxy-importer SUCCESS in 3m 38s
✔️ build-ansible-collection SUCCESS in 12m 26s
❌ ansible-test-sanity-docker-devel FAILURE in 9m 56s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 8m 53s (non-voting)
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 12m 01s
❌ ansible-test-sanity-docker-stable-2.13 FAILURE in 12m 48s
❌ ansible-test-sanity-docker-stable-2.14 FAILURE in 12m 00s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 38s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 40s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 36s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 58s
❌ ansible-test-changelog FAILURE in 4m 19s
✔️ ansible-test-splitter SUCCESS in 4m 41s
❌ integration-community.aws-1 FAILURE in 7m 45s
Skipped 21 jobs

@softwarefactory-project-zuul

This comment was marked as resolved.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as resolved.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as resolved.

Sign in to view
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a191c3a5f5994f789362fce392ac2c65

✔️ ansible-galaxy-importer SUCCESS in 4m 21s
✔️ build-ansible-collection SUCCESS in 12m 40s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 16s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 06s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 16s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 57s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 01s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 42s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 51s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 16s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 38s
✔️ ansible-test-changelog SUCCESS in 4m 20s
✔️ ansible-test-splitter SUCCESS in 4m 36s
✔️ integration-community.aws-1 SUCCESS in 6m 14s
Skipped 21 jobs

tremble
tremble approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this looks good. Thanks for taking the time to submit this PR.

One small thing, when adding parameters we also add a "version_added" entry to the docs for that parameter.

I'll push that small change and we can get this merged.

@tremble tremble force-pushed the sns-add-support-for-fifo-topics branch from e9a4457 to 512ff23 Compare March 14, 2023 10:59
@tremble tremble added the backport-5 PR should be backported to the stable-5 branch label Mar 14, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d7058d494a1c40d1ac91f7abd56bdfd5

❌ ansible-galaxy-importer FAILURE in 3m 47s
✔️ build-ansible-collection SUCCESS in 13m 04s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 23s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 58s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 51s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 47s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 00s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 16s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 30s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 49s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 12s
✔️ ansible-test-changelog SUCCESS in 4m 22s
✔️ ansible-test-splitter SUCCESS in 4m 41s
✔️ integration-community.aws-1 SUCCESS in 5m 33s
Skipped 21 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Mar 14, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/3c5a2ffd5ff84cf2a2b5dc5677bccf72

✔️ ansible-galaxy-importer SUCCESS in 4m 26s
✔️ build-ansible-collection SUCCESS in 12m 48s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 11s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 22s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 25s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 49s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 23s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 23s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 12s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 59s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 08s
✔️ ansible-test-changelog SUCCESS in 4m 38s
✔️ ansible-test-splitter SUCCESS in 4m 48s
✔️ integration-community.aws-1 SUCCESS in 7m 36s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b1b67a2 into ansible-collections:main Mar 14, 2023
@patchback
Copy link

patchback bot commented Mar 14, 2023 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/b1b67a259fac94f2d48ea32cfd94488c99a48618/pr-1733

Backported as #1748

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 14, 2023
@Pascal-Architrave @patchback
sns: Add parameters for fifo topics (#1733)
9774bc1 
sns: Add parameters for fifo topics

SUMMARY
Implements #1718. Adding message_group_id and message_deduplication_id to support publishing of messages to fifo topics.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
sns

Reviewed-by: Mark Chappell
(cherry picked from commit b1b67a2)
@patchback patchback bot mentioned this pull request Mar 14, 2023
Merged
@Pascal-Architrave
Copy link
Contributor Author

@tremble Thank you very much! :)

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 14, 2023
@patchback
sns: Add parameters for fifo topics (#1733) (#1748)
cd8b934 
[PR #1733/b1b67a25 backport][stable-5] sns: Add parameters for fifo topics

This is a backport of PR #1733 as merged into main (b1b67a2).
SUMMARY
Implements #1718. Adding message_group_id and message_deduplication_id to support publishing of messages to fifo topics.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
sns

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
backport-5 PR should be backported to the stable-5 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pascal-Architrave @tremble