Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1716/86c60b49 backport][stable-5] ecs: integration test and new purge parameters #1731

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 1, 2023

This is a backport of PR #1716 as merged into main (86c60b4).

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

ecs_service

ADDITIONAL INFORMATION

works for me again

ansible-test integration --python 3.10 ecs_cluster --docker --allow-unsupported
...
PLAY RECAP *********************************************************************
testhost                   : ok=143  changed=69   unreachable=0    failed=0    skipped=1    rescued=0    ignored=6   

ecs: integration test and new purge parameters

SUMMARY

Make the ecs_cluster integration test work again
ecs_service - new parameter purge_placement_constraints and purge_placement_strategy. Otherwise it is impossible to remove those placements without breaking backwards compatibility.

purge_placement_constraints in the integration test
purge_placement_strategy in the integration test

required by mattclay/aws-terminator#210 (comment)

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request

COMPONENT NAME
ecs_service
ADDITIONAL INFORMATION
works for me again
ansible-test integration --python 3.10 ecs_cluster --docker --allow-unsupported
...
PLAY RECAP *********************************************************************
testhost                   : ok=143  changed=69   unreachable=0    failed=0    skipped=1    rescued=0    ignored=6

Reviewed-by: Mark Chappell
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mike Graves <[email protected]>
(cherry picked from commit 86c60b4)
@tremble tremble added this to the 5.3.0 milestone Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/49f6aa885e034bafb822be0c1702572d

✔️ ansible-galaxy-importer SUCCESS in 3m 45s
✔️ build-ansible-collection SUCCESS in 12m 41s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 43s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 35s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 51s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 51s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 31s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 39s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 27s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 32s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 25s
✔️ ansible-test-changelog SUCCESS in 4m 16s
✔️ ansible-test-splitter SUCCESS in 4m 48s
✔️ integration-community.aws-1 SUCCESS in 19m 38s
Skipped 21 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Mar 1, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/06a96e1a461c4bc3aaefb1520a565f27

ansible-galaxy-importer FAILURE in 5m 22s
✔️ build-ansible-collection SUCCESS in 12m 20s
✔️ ansible-test-sanity-docker-devel SUCCESS in 24m 00s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 36m 37s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 13m 44s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 58s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 16s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 59s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 19m 16s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 30s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 7m 24s
✔️ ansible-test-changelog SUCCESS in 4m 17s
✔️ ansible-test-splitter SUCCESS in 4m 43s
✔️ integration-community.aws-1 SUCCESS in 19m 41s
Skipped 21 jobs

@markuman
Copy link
Member

markuman commented Mar 1, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/d931a94bb4d14799b3056035ed7d61f3

✔️ ansible-galaxy-importer SUCCESS in 4m 34s
✔️ build-ansible-collection SUCCESS in 12m 54s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 14s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 14m 57s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 20m 09s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 15s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 54s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 22s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 26s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 29s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 7m 01s
✔️ ansible-test-changelog SUCCESS in 4m 40s
✔️ ansible-test-splitter SUCCESS in 4m 44s
✔️ integration-community.aws-1 SUCCESS in 29m 44s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6744af6 into stable-5 Mar 1, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/86c60b4957a2baa0bc8b00ef1ed9adf90a56ed9c/pr-1716 branch March 1, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants