SNS: content-based deduplication #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alinabuzachis looks like you were good with #1602 - this just adds integration tests and rebases. Could I get a quick review please |
ansibullbot
added
community_review
feature
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as resolved.
This comment was marked as resolved.
alinabuzachis
approved these changes
Feb 2, 2023
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1695 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
SNS: content-based deduplication SUMMARY Original Author: redradrat Original PR: #1602 Adds the missing option of "content-based deduplication" for fifo topics. Also fixes looking up fifo topic ARNs, which resulted in changing always be True. ISSUE TYPE Feature Pull Request COMPONENT NAME sns_topic ADDITIONAL INFORMATION #1602 is missing tests and has merge conflicts. Fixes the conflicts and adds integration tests Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit aace7ff)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
[PR #1693/aace7ff5 backport][stable-5] SNS: content-based deduplication This is a backport of PR #1693 as merged into main (aace7ff). SUMMARY Original Author: redradrat Original PR: #1602 Adds the missing option of "content-based deduplication" for fifo topics. Also fixes looking up fifo topic ARNs, which resulted in changing always be True. ISSUE TYPE Feature Pull Request COMPONENT NAME sns_topic ADDITIONAL INFORMATION #1602 is missing tests and has merge conflicts. Fixes the conflicts and adds integration tests Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Original Author: redradrat
Original PR: #1602
Adds the missing option of "content-based deduplication" for fifo topics.
Also fixes looking up fifo topic ARNs, which resulted in changing always be True.
ISSUE TYPE
COMPONENT NAME
sns_topic
ADDITIONAL INFORMATION
#1602 is missing tests and has merge conflicts.
Fixes the conflicts and adds integration tests