-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #1575/7a2b5d98 backport][stable-5] ssm_parameter: add support for tags (#1573) #1691
Merged
softwarefactory-project-zuul
merged 1 commit into
stable-5
from
patchback/backports/stable-5/7a2b5d98cf9c71dfa36d862471ecd3083c9e4b1f/pr-1575
Feb 2, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssm_parameter: add support for tags (#1573) SUMMARY Adding support for tags following community guidelines and other practices from other modules. secretsmanager_secret was used along with helper functions from ec2 code. Addresses open issue for feature request #1573. ISSUE TYPE Feature Pull Request COMPONENT NAME ssm_parameter ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Michael Haskell (mikehas) <None> Reviewed-by: Dennis Qian <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Chappell <None> (cherry picked from commit 7a2b5d9)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
module
module
needs_triage
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
tests
tests
labels
Feb 2, 2023
tremble
approved these changes
Feb 2, 2023
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-5/7a2b5d98cf9c71dfa36d862471ecd3083c9e4b1f/pr-1575
branch
February 2, 2023 11:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
mergeit
Merge the PR (SoftwareFactory)
module
module
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1575 as merged into main (7a2b5d9).
SUMMARY
Adding support for tags following community guidelines and other practices from other modules. secretsmanager_secret was used along with helper functions from ec2 code. Addresses open issue for feature request #1573.
ISSUE TYPE
COMPONENT NAME
ssm_parameter
ADDITIONAL INFORMATION