Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1575/7a2b5d98 backport][stable-5] ssm_parameter: add support for tags (#1573) #1691

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Feb 2, 2023

This is a backport of PR #1575 as merged into main (7a2b5d9).

SUMMARY

Adding support for tags following community guidelines and other practices from other modules. secretsmanager_secret was used along with helper functions from ec2 code. Addresses open issue for feature request #1573.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ssm_parameter

ADDITIONAL INFORMATION

ssm_parameter: add support for tags (#1573)

SUMMARY

Adding support for tags following community guidelines and other practices from other modules. secretsmanager_secret was used along with helper functions from ec2 code. Addresses open issue for feature request #1573.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Michael Haskell (mikehas) <None>
Reviewed-by: Dennis Qian <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit 7a2b5d9)
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 48s
✔️ build-ansible-collection SUCCESS in 5m 43s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 57s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 36s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 53s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 40s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 29s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 09s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 37s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 55s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 37s
✔️ ansible-test-changelog SUCCESS in 2m 29s
✔️ ansible-test-splitter SUCCESS in 2m 40s
✔️ integration-community.aws-1 SUCCESS in 6m 34s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Feb 2, 2023
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Feb 2, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 37s
✔️ build-ansible-collection SUCCESS in 5m 42s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 04s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 13s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 59s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 34s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 05s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 20s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 54s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 42s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 39s
✔️ ansible-test-changelog SUCCESS in 2m 17s
✔️ ansible-test-splitter SUCCESS in 2m 30s
✔️ integration-community.aws-1 SUCCESS in 6m 49s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4cf180b into stable-5 Feb 2, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/7a2b5d98cf9c71dfa36d862471ecd3083c9e4b1f/pr-1575 branch February 2, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants