-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_ssm - Drop extra sudo call on most commands. #1682
Merged
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:issues/853
Jan 31, 2023
Merged
aws_ssm - Drop extra sudo call on most commands. #1682
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:issues/853
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
added
the
do_not_backport
This PR should not be backported to stable- branches unless absolutely necessary
label
Jan 28, 2023
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
bug
This issue/PR relates to a bug
community_review
connection
connection plugin
integration
tests/integration
plugins
plugin (any type)
tests
tests
labels
Jan 28, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
fixes: ansible-collections#853 The aws_ssm connection plugin was prepending additional `sudo` calls to most commands executed. This resulted in commands generally being executed as the `root` user, even when `become` was set to `False`.
alinabuzachis
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue/PR relates to a bug
community_review
connection
connection plugin
do_not_backport
This PR should not be backported to stable- branches unless absolutely necessary
integration
tests/integration
mergeit
Merge the PR (SoftwareFactory)
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #853
SUMMARY
The aws_ssm connection plugin was prepending additional
sudo
calls to most commands executed. This resulted in commands generally being executed as theroot
user, even whenbecome
was set toFalse
.ISSUE TYPE
COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION