Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ssm - Drop extra sudo call on most commands. #1682

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 28, 2023

fixes: #853

SUMMARY

The aws_ssm connection plugin was prepending additional sudo calls to most commands executed. This resulted in commands generally being executed as the root user, even when become was set to False.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_ssm

ADDITIONAL INFORMATION

@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label Jan 28, 2023
@github-actions
Copy link

github-actions bot commented Jan 28, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review connection connection plugin integration tests/integration plugins plugin (any type) tests tests labels Jan 28, 2023
@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

fixes: ansible-collections#853

The aws_ssm connection plugin was prepending additional `sudo` calls to most commands executed.  This resulted in commands generally being executed as the `root` user, even when `become` was set to `False`.
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 44s
✔️ build-ansible-collection SUCCESS in 6m 00s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 51s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 33s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 00s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 52s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 07s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 57s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 43s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 57s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 7m 04s
✔️ ansible-test-changelog SUCCESS in 2m 19s
✔️ ansible-test-splitter SUCCESS in 3m 13s
✔️ integration-community.aws-1 SUCCESS in 9m 33s
✔️ integration-community.aws-2 SUCCESS in 8m 24s
✔️ integration-community.aws-3 SUCCESS in 9m 32s
✔️ integration-community.aws-4 SUCCESS in 8m 56s
✔️ integration-community.aws-5 SUCCESS in 9m 24s
✔️ integration-community.aws-6 SUCCESS in 10m 03s
✔️ integration-community.aws-7 SUCCESS in 9m 15s
✔️ integration-community.aws-8 SUCCESS in 9m 52s
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@tremble tremble marked this pull request as ready for review January 31, 2023 08:13
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 31, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 14s
✔️ build-ansible-collection SUCCESS in 6m 05s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 20s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 37s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 40s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 25s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 08s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 12m 33s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 19s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 10s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 07s
✔️ ansible-test-changelog SUCCESS in 2m 36s
✔️ ansible-test-splitter SUCCESS in 2m 48s
✔️ integration-community.aws-1 SUCCESS in 10m 06s
✔️ integration-community.aws-2 SUCCESS in 9m 16s
✔️ integration-community.aws-3 SUCCESS in 10m 40s
✔️ integration-community.aws-4 SUCCESS in 9m 48s
✔️ integration-community.aws-5 SUCCESS in 9m 13s
✔️ integration-community.aws-6 SUCCESS in 8m 43s
✔️ integration-community.aws-7 SUCCESS in 10m 35s
✔️ integration-community.aws-8 SUCCESS in 7m 47s
✔️ integration-community.aws-9 SUCCESS in 9m 09s
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2356d3d into ansible-collections:main Jan 31, 2023
@tremble tremble deleted the issues/853 branch February 15, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review connection connection plugin do_not_backport This PR should not be backported to stable- branches unless absolutely necessary integration tests/integration mergeit Merge the PR (SoftwareFactory) plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS SSM connection user is always root
3 participants