aws_ssm - Add gather_facts to integration tests for connection plugins #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
|
recheck |
softwarefactory-project-zuul bot
pushed a commit
to ansible/ansible-zuul-jobs
that referenced
this pull request
Jan 23, 2023
Add ansible.windows as a dependency for the community.aws tests The aws_ssm connection plugin depends on ansible.windows to test connections to Windows instances ansible-collections/community.aws#1670 Reviewed-by: Bikouo Aubin <None>
alinabuzachis
approved these changes
Jan 23, 2023
|
recheck |
|
Build failed (gate pipeline). For information on how to proceed, see Warning: |
|
regate |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1675 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
#1670) aws_ssm - Add gather_facts to integration tests for connection plugins Depends-On: ansible/ansible-zuul-jobs#1752 SUMMARY gather_facts stalling out was one of the examples given for things broken with aws_ssm ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> (cherry picked from commit 93c2485)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
#1670) (#1675) [PR #1670/93c2485c backport][stable-5] aws_ssm - Add gather_facts to integration tests for connection plugins This is a backport of PR #1670 as merged into main (93c2485). Depends-On: ansible/ansible-zuul-jobs#1752 SUMMARY gather_facts stalling out was one of the examples given for things broken with aws_ssm ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
…1674) aws_ssm - split S3 region/endpoint discovery into dedicated function Depends-On: #1670 SUMMARY fixes: #1616 Newer AWS regions don't generate valid presigned URLs unless you explicitly pass the endpoint_url for the region (see also boto/boto3#3015) ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
patchback bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
…1674) aws_ssm - split S3 region/endpoint discovery into dedicated function Depends-On: #1670 SUMMARY fixes: #1616 Newer AWS regions don't generate valid presigned URLs unless you explicitly pass the endpoint_url for the region (see also boto/boto3#3015) ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 8237ebb)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
…1674) (#1677) [PR #1674/8237ebb7 backport][stable-5] aws_ssm - split S3 region/endpoint discovery into dedicated function This is a backport of PR #1674 as merged into main (8237ebb). Depends-On: #1670 SUMMARY fixes: #1616 Newer AWS regions don't generate valid presigned URLs unless you explicitly pass the endpoint_url for the region (see also boto/boto3#3015) ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Default filters to empty dictionary SUMMARY Changes the default for the filters option from None to an empty dictionary. Fixes: ansible-collections#1668 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_route_table_info ADDITIONAL INFORMATION This matches what other *info modules (e.g. ec2_vpc_endpoint_info or ec2_vpc_subnet_info) do for the filters option default. Reviewed-by: Alina Buzachis Reviewed-by: Brant Evans <[email protected]> Reviewed-by: Mark Chappell Reviewed-by: Mike Graves <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/ansible-zuul-jobs#1752
SUMMARY
gather_facts stalling out was one of the examples given for things broken with aws_ssm
ISSUE TYPE
COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION