[PR #1633/8503d80d backport][stable-5] Addressing Style S3 (ssm_connection) - choose between path, virtual or auto. #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…r auto. (#1633) Addressing Style S3 (ssm_connection) - choose between path, virtual or auto. SUMMARY Added the chance of setting up the addressing style for S3 URLs, this fixes #637 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION I came across this issue when I was trying to connect and execute tasks on a fresh AWS set-up (new S3 bucket + EC2), I'm using the latest (5.1.0) release and Ansible 5.10 (as per pip show). The issue itself is the same as #637 and the last comment is the fix, there's another PR addressing this issue #786 but is quiet since May Also AWS seems to be deprecating PATH addressing style: https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access Thanks to timburnet-systematica and james-masson for their initial work on this. Reviewed-by: Mark Chappell <None> (cherry picked from commit 8503d80)
ansibullbot
added
community_review
connection
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
approved these changes
Jan 20, 2023
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-5/8503d80d2c8477bd1601d419bb73e51bb691498f/pr-1633
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1633 as merged into main (8503d80).
SUMMARY
Added the chance of setting up the addressing style for S3 URLs, this fixes #637
ISSUE TYPE
COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION
I came across this issue when I was trying to connect and execute tasks on a fresh AWS set-up (new S3 bucket + EC2), I'm using the latest (5.1.0) release and Ansible 5.10 (as per pip show).
The issue itself is the same as #637 and the last comment is the fix, there's another PR addressing this issue #786 but is quiet since May
Also AWS seems to be deprecating PATH addressing style: https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access
Thanks to timburnet-systematica and james-masson for their initial work on this.