SSM connection plugin - Add encryption tests #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markuman added your ssm_parameter suggestion |
ansibullbot
added
community_review
feature
This comment was marked as resolved.
This comment was marked as resolved.
|
hmm
The parameter itself is correct |
|
@markuman Yeah, I've tested it locally. mattclay/aws-terminator#255 is the missing permission. |
|
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
|
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
|
recheck |
|
recheck |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1658 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
SSM connection plugin - Add encryption tests Depends-On: ansible/ansible-zuul-jobs#1746 SUMMARY Expand on the aws_ssm connection integration tests Follow up on suggestion to use ssm_parameter to locate AMIs Add tests for connection using encrypted buckets ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION (cherry picked from commit 34e073d)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
[PR #1657/34e073d5 backport][stable-5] SSM connection plugin - Add encryption tests This is a backport of PR #1657 as merged into main (34e073d). Depends-On: ansible/ansible-zuul-jobs#1746 SUMMARY Expand on the aws_ssm connection integration tests Follow up on suggestion to use ssm_parameter to locate AMIs Add tests for connection using encrypted buckets ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. (ansible-collections#1657) rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode SUMMARY Add AllocatedStorage, DBClusterInstanceClass, StorageType, Iops and EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_cluster Reviewed-by: Taeho Park Reviewed-by: Mike Graves <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/ansible-zuul-jobs#1746
SUMMARY
Expand on the aws_ssm connection integration tests
ISSUE TYPE
COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION