-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #1629/5aa3ff17 backport][stable-4] make s3_lifecycle not call put_lifecycle_configuration if there is no… #1647
Merged
softwarefactory-project-zuul
merged 1 commit into
stable-4
from
patchback/backports/stable-4/5aa3ff17c24feb9facc327bff9f68482210c024d/pr-1629
Jan 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… change to put (#1629) make s3_lifecycle not call put_lifecycle_configuration if there is no… SUMMARY Fixes #1624 ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION I have not written integration tests for this. My MWE in #1624 used multiple hosts (all localhost). I don't know how to add that here. Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 5aa3ff1)
ansibullbot
added
bug
This issue/PR relates to a bug
community_review
module
module
needs_triage
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
labels
Jan 11, 2023
markuman
approved these changes
Jan 12, 2023
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-4/5aa3ff17c24feb9facc327bff9f68482210c024d/pr-1629
branch
January 12, 2023 16:32
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…#1647) Added started and stopped states for rds cluster SUMMARY Fixes ansible-collections#1616 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/rds_cluster.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue/PR relates to a bug
community_review
mergeit
Merge the PR (SoftwareFactory)
module
module
needs_triage
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1629 as merged into main (5aa3ff1).
SUMMARY
Fixes #1624
ISSUE TYPE
COMPONENT NAME
s3_lifecycle
ADDITIONAL INFORMATION
I have not written integration tests for this. My MWE in #1624 used multiple hosts (all localhost). I don't know how to add that here.