Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1629/5aa3ff17 backport][stable-4] make s3_lifecycle not call put_lifecycle_configuration if there is no… #1647

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jan 11, 2023

This is a backport of PR #1629 as merged into main (5aa3ff1).

SUMMARY

Fixes #1624

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

s3_lifecycle

ADDITIONAL INFORMATION

I have not written integration tests for this. My MWE in #1624 used multiple hosts (all localhost). I don't know how to add that here.

… change to put (#1629)

make s3_lifecycle not call put_lifecycle_configuration if there is no…

SUMMARY
Fixes #1624
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_lifecycle
ADDITIONAL INFORMATION
I have not written integration tests for this. My MWE in #1624 used multiple hosts (all localhost). I don't know how to add that here.

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 5aa3ff1)
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Jan 11, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 33s
✔️ build-ansible-collection SUCCESS in 6m 08s
ansible-test-sanity-docker-devel FAILURE in 10m 30s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 10m 24s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 28s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 31s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 07s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 02s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 34s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 44s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 50s
✔️ ansible-test-changelog SUCCESS in 2m 36s
✔️ ansible-test-splitter SUCCESS in 2m 38s
✔️ integration-community.aws-1 SUCCESS in 23m 16s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Jan 12, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 27s
✔️ build-ansible-collection SUCCESS in 6m 22s
ansible-test-sanity-docker-devel FAILURE in 10m 07s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 10m 23s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 24s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 38s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 42s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 31s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 21s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 50s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 38s
✔️ ansible-test-changelog SUCCESS in 2m 49s
✔️ ansible-test-splitter SUCCESS in 2m 45s
✔️ integration-community.aws-1 SUCCESS in 25m 42s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d0c5238 into stable-4 Jan 12, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-4/5aa3ff17c24feb9facc327bff9f68482210c024d/pr-1629 branch January 12, 2023 16:32
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…#1647)

Added started and stopped states for rds cluster

SUMMARY

Fixes ansible-collections#1616

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

plugins/modules/rds_cluster.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Mike Graves <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants