Attempt to improve the stability of ec2_vpc_vgw and ec2_vpc_vpn #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
stability/ec2_vpc_vgw/mutating_objects
branch
2 times, most recently
from
1c84d22 to
e9acf96
Compare
|
Migration to wrapped clients has broken the unit tests, will need to dig into those to fix |
|
Need to fix unit tests to cope with wrapped client |
ansibullbot
added
WIP
tremble
force-pushed
the
stability/ec2_vpc_vgw/mutating_objects
branch
from
582f048 to
03902f7
Compare
ansibullbot
removed
the
needs_rebase
tremble
force-pushed
the
stability/ec2_vpc_vgw/mutating_objects
branch
3 times, most recently
from
7a53bcb to
dfd6390
Compare
tremble
changed the title
|
@tremble I noticed you took the WIP off this. What you have here looks good, were you still working on the unit tests? |
ansibullbot
added
needs_revision
tremble
changed the title
|
@jillr Unit tests still need updating, I thought it was done and then realised that the unit tests weren't being run |
…r of mutating objects has been reached'
tremble
force-pushed
the
stability/ec2_vpc_vgw/mutating_objects
branch
from
dfd6390 to
7b440b5
Compare
ansibullbot
added
needs_maintainer
tests
tremble
force-pushed
the
stability/ec2_vpc_vgw/mutating_objects
branch
from
7b440b5 to
283bbd7
Compare
tremble
changed the title
|
@jillr ok. Unit tests fixed. (rolls eyes at how stupidly simple the fix was) |
tremble
removed
needs_revision
ansibullbot
added
the
needs_revision
tremble
removed
the
needs_revision
alinabuzachis
approved these changes
Mar 15, 2021
|
Tests passing and approved. Merging |
danquixote
pushed a commit
to danquixote/community.aws
that referenced
this pull request
May 16, 2021
…ble-collections#162) * Add a custom Retry so we can retry when we receive 'The maximum number of mutating objects has been reached' * Update ec2_vpc_vpn unit test to use a connection with an AWSRetry decorator * changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…_vpn (ansible-collections#162) * Add a custom Retry so we can retry when we receive 'The maximum number of mutating objects has been reached' * Update ec2_vpc_vpn unit test to use a connection with an AWSRetry decorator * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@79e0928
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ble-collections#162) * Add a custom Retry so we can retry when we receive 'The maximum number of mutating objects has been reached' * Update ec2_vpc_vpn unit test to use a connection with an AWSRetry decorator * changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ble-collections#162) * Add a custom Retry so we can retry when we receive 'The maximum number of mutating objects has been reached' * Update ec2_vpc_vpn unit test to use a connection with an AWSRetry decorator * changelog
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
…ble-collections#162) * Add a custom Retry so we can retry when we receive 'The maximum number of mutating objects has been reached' * Update ec2_vpc_vpn unit test to use a connection with an AWSRetry decorator * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
With the increased concurrency of tests we've started hitting 'The maximum number of mutating objects has been reached.'
Unfortunately AWS uses the same Error Code for 'Too much changing' as 'Too many VPNs/VGWs', so we need to tweak the retry class a little
fixes: #156
fixes: #154
ISSUE TYPE
COMPONENT NAME
ec2_vpc_vgw
ec2_vpc_vpn
ADDITIONAL INFORMATION
See attached issues for example failures