s3_lifecycle - ability to set the number of newest noncurrent versions to retain #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davejames
force-pushed
the
s3_lifecycle_num_noncurrent_versions
branch
from
1837c90 to
aadfa5f
Compare
ansibullbot
added
community_review
feature
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
markuman
reviewed
Nov 28, 2022
|
@davejames can you also expand the integration test to verify the new parameter? tests/integration/targets/s3_lifecycle/tasks/main.yml |
tremble
force-pushed
the
s3_lifecycle_num_noncurrent_versions
branch
from
aadfa5f to
40fba8d
Compare
tremble
approved these changes
Feb 1, 2023
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1687 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
…s to retain (#1606) s3_lifecycle - ability to set the number of newest noncurrent versions to retain SUMMARY Adds the ability to set "Number of newer versions to retain" ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION See: https://docs.aws.amazon.com/AmazonS3/latest/API/API_NoncurrentVersionExpiration.html Previously only the NoncurrentDays parameter was supported, this PR adds support for NewerNoncurrentVersions Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Chappell <None> (cherry picked from commit 3391b27)
|
@davejames Thanks for taking the time to submit this PR. |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
…s to retain (#1606) (#1687) [PR #1606/3391b27d backport][stable-5] s3_lifecycle - ability to set the number of newest noncurrent versions to retain This is a backport of PR #1606 as merged into main (3391b27). SUMMARY Adds the ability to set "Number of newer versions to retain" ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION See: https://docs.aws.amazon.com/AmazonS3/latest/API/API_NoncurrentVersionExpiration.html Previously only the NoncurrentDays parameter was supported, this PR adds support for NewerNoncurrentVersions Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds the ability to set "Number of newer versions to retain"
ISSUE TYPE
COMPONENT NAME
s3_lifecycle
ADDITIONAL INFORMATION
See: https://docs.aws.amazon.com/AmazonS3/latest/API/API_NoncurrentVersionExpiration.html
Previously only the
NoncurrentDaysparameter was supported, this PR adds support forNewerNoncurrentVersions