cloudfront_distribution: Add support for cache_policy_id and origin_request_policy_id for behaviors #1589
Conversation
…gin_request_policy_id to cache behaviors
…gin_request_policy_id to cache behaviors
Zozman
changed the title
…gin_request_policy_id to cache behaviors
ansibullbot
added
community_review
feature
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 49s |
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 09s |
|
@Zozman this is the integration test error
Without digging deeper, I cannot say if it is a bug in the integration test or if it is a side effect of the changed code. |
|
@markuman Thanks for the heads up; wouldn't surprise me if I messed it up so will try to see what's up. Most likely I messed it up somewhere. |
… to the rule (ansible-collections#1589) cloudwatchevent_rule should return false when there is no change done to the rule SUMMARY Fixes ansible-collections#1080 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/cloudwatchevent_rule.py ADDITIONAL INFORMATION Reviewed-by: GomathiselviS Reviewed-by: Mark Chappell Reviewed-by: Jill R Reviewed-by: Alina Buzachis
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 50s (non-voting) |
…equest_policy_id for behaviors
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 11s (non-voting) |
|
recheck |
|
Build failed.
|
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 32s (non-voting) |
|
ready_for_review |
|
Are the errors in the sanity tests something caused by my PR I can fix? It looks like an issue with the job installing dependencies. |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 36s (non-voting) |
Just an FYI, I am getting the same error when I install the branch locally using: ---
# roles:
# Install a role from Ansible Galaxy.
# - name: sample
# version: 1.9.6
collections:
- name: https://github.com/zozman/community.aws.git # TODO this should be changed to upstream as described in https://github.com/walkerart/devops/issues/12
type: git
version: cloudfrontCachePolicy
The output when running the install command is: $ ansible-galaxy install -r roles/requirements.yml
Starting galaxy collection install process
Process install dependency map
Cloning into '/home/eric/.ansible/tmp/ansible-local-2782030qm8bz_di/tmpd9m5wrhl/community.awscmy49o1k'...
remote: Enumerating objects: 20379, done.
remote: Counting objects: 100% (7479/7479), done.
remote: Compressing objects: 100% (2455/2455), done.
remote: Total 20379 (delta 5233), reused 6757 (delta 4877), pack-reused 12900
Receiving objects: 100% (20379/20379), 9.56 MiB | 4.52 MiB/s, done.
Resolving deltas: 100% (13820/13820), done.
Branch 'cloudfrontCachePolicy' set up to track remote branch 'cloudfrontCachePolicy' from 'origin'.
Switched to a new branch 'cloudfrontCachePolicy'
ERROR! Failed to resolve the requested dependencies map. Could not satisfy the following requirements:
* amazon.aws:>=8.0.0-dev0 (dependency of community.aws:8.0.0-dev0) |
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 13s (non-voting) |
|
recheck |
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 28s (non-voting) |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 06s (non-voting) |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 7m 05s (non-voting) |
|
bot_status |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 38s (non-voting) |
softwarefactory-project-zuul
bot
merged commit 7da2ed5
into
ansible-collections:main
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #2038 🤖 @patchback |
…equest_policy_id for behaviors (#1589) cloudfront_distribution: Add support for cache_policy_id and origin_request_policy_id for behaviors SUMMARY As described by issue #290, the current cloudfront_distribution module does not support cache_policy_id and origin_request_policy_id in a behavior. In particular, attempting to use cache_policy_id will add default values that are incompatible with it (mainly default_ttl, max_ttl, min_ttl, and compress). So this change allows you to use the policies instead of using a forwarded_values for a given behavior. Fixed #290 ISSUE TYPE Feature Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Zac Lovoy Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis (cherry picked from commit 7da2ed5)
…equest_policy_id for behaviors (#1589) (#2038) [PR #1589/7da2ed5c backport][stable-7] cloudfront_distribution: Add support for cache_policy_id and origin_request_policy_id for behaviors This is a backport of PR #1589 as merged into main (7da2ed5). SUMMARY As described by issue #290, the current cloudfront_distribution module does not support cache_policy_id and origin_request_policy_id in a behavior. In particular, attempting to use cache_policy_id will add default values that are incompatible with it (mainly default_ttl, max_ttl, min_ttl, and compress). So this change allows you to use the policies instead of using a forwarded_values for a given behavior. Fixed #290 ISSUE TYPE Feature Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Mark Chappell
|
Thank you so much @Zozman, this is super helpful! |
SUMMARY
As described by issue #290, the current
cloudfront_distributionmodule does not supportcache_policy_idandorigin_request_policy_idin a behavior. In particular, attempting to usecache_policy_idwill add default values that are incompatible with it (mainlydefault_ttl,max_ttl,min_ttl, andcompress). So this change allows you to use the policies instead of using aforwarded_valuesfor a given behavior.Fixed #290
ISSUE TYPE
COMPONENT NAME
cloudfront_distribution