Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 3.6.0 release #1549

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 6, 2022

SUMMARY

One last one for the road.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

changelogs
galaxy.yml

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request needs_triage labels Oct 6, 2022
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Oct 7, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 10m 49s
✔️ build-ansible-collection SUCCESS in 5m 28s
ansible-test-sanity-docker-devel FAILURE in 18m 12s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 17m 03s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 18m 26s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 19m 33s
ansible-test-sanity-docker-stable-2.14 FAILURE in 17m 53s (non-voting)
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 15m 58s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 15m 45s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 13m 15s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit bb92137 into ansible-collections:stable-3 Oct 7, 2022
@tremble tremble deleted the release/3.6.0/prep branch February 15, 2023 09:25
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…nsible-collections#1549)

s3_object - fix regression related to leading / in object key names

SUMMARY
fixes ansible-collections#1548
S3 object key names should not include a leading / (https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html).  However, for historical reasons we've supported them (we just pruned them out) this pruning was dropped in 6.0.0 without warning.
For the sake of simplifying things and moving closer to the actual AWS resources, deprecate pruning out the leading /.  (Arbitrarily modifying inputs and resource names tends to lead to strange edge cases)
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_object
ADDITIONAL INFORMATION
Regression of ansible/ansible#30576 / ansible/ansible#30579

Reviewed-by: Alina Buzachis
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
ansible-collections#1555)

s3_object - deprecate leading slash in object keys

SUMMARY
Deprecate support for removing leading / from object names
AWS APIs don't expect it to be there, pruning it may cause pain in future
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
s3_object
ADDITIONAL INFORMATION
Deprecation was split from ansible-collections#1549

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) needs_triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants