[PR #1468/1cd7cebb backport][stable-4] tests/autoscaling_{group,lifecycle_hook}: use setup_ec2_facts #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
tests/autoscaling_{group,lifecycle_hook}: use setup_ec2_facts
amzn2-ami-hvm-2.0.20190612-x86_64-gp2 is not available anymore, we now use setup_ec2_facts to get the right AMI ID.
Reviewed-by: Mark Chappell <None>
(cherry picked from commit 1cd7ceb)
This comment was marked as off-topic.
This comment was marked as off-topic.
ansibullbot
added
integration
tremble
approved these changes
Sep 19, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-4/1cd7cebba362c186611af208cc82095404536af9/pr-1468
branch
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Sep 20, 2022
[PR #1410/3d4736bb backport][stable-4] Minor sanity test fixes (new devel) Depends-On: #1499 This is a backport of PR #1410 as merged into main (3d4736b). SUMMARY ansible-devel has added a new PEP test (missing whitespace after keyword), this adds the fixes before the devel sanity tests are 'voting'. Additionally fixes: unused variables broad catching of Exception ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/autoscaling_group_info.py plugins/modules/cloudfront_distribution.py plugins/modules/cloudfront_origin_access_identity.py plugins/modules/cloudtrail.py plugins/modules/ec2_vpc_nacl.py plugins/modules/eks_fargate_profile.py plugins/modules/redshift.py plugins/modules/s3_bucket_info.py ADDITIONAL INFORMATION cloudfront_distribution still has a lot of catch Exception but it's part of parameter validation which should be overhauled separately, unfortunately the tests are rather b0rked. Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Manually merged (.github/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1468 as merged into main (1cd7ceb).
amzn2-ami-hvm-2.0.20190612-x86_64-gp2is not available anymore, we now usesetup_ec2_factsto get the right AMI ID.