tests/acm_certificate: retries aws_acm_info called when needed #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
integration
The `aws_acm_info` may return an empty list if a certificate has just been recreated. We now retries 3 times until we've got a list.
goneri
force-pushed
the
tests-acm_certificate-retries-a-aws_acm_info-if-needed_4392
branch
from
7b24ab7 to
eeed91a
Compare
goneri
changed the title
|
@goneri this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Sep 16, 2022
…#1467) tests/integration: ensure the CI gives more time to some slow targets Depends-On: ansible/ansible-zuul-jobs#1625 Depends-On: #1468 Depends-On: #1473 Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
aws_acm_infomay return an empty list if a certificate has just been recreated (race condition). We now retry 3 times until we've got a list.