Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudfront_distribution: add connection_attempts and connection_timeout parameters #1435

Conversation

eRadical
Copy link
Contributor

@eRadical eRadical commented Sep 5, 2022

Depends-On: #1569

SUMMARY

Missing connection_attempts & connection_timeout.
Closes #1434.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

cloudfront_distribution

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Sep 5, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 28s
✔️ build-ansible-collection SUCCESS in 5m 19s
ansible-test-sanity-docker-devel FAILURE in 11m 26s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 10m 47s
ansible-test-sanity-docker-stable-2.12 FAILURE in 12m 35s
ansible-test-sanity-docker-stable-2.13 FAILURE in 8m 51s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 11s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 36s
✔️ ansible-test-splitter SUCCESS in 2m 31s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 02s
✔️ build-ansible-collection SUCCESS in 5m 45s
ansible-test-sanity-docker-devel FAILURE in 10m 03s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 10m 49s
ansible-test-sanity-docker-stable-2.12 FAILURE in 10m 22s
ansible-test-sanity-docker-stable-2.13 FAILURE in 8m 56s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 52s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 37s
✔️ ansible-test-splitter SUCCESS in 2m 29s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 16s
✔️ build-ansible-collection SUCCESS in 4m 56s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 14s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 34s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 38s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 20s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 25s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 56s
✔️ ansible-test-splitter SUCCESS in 2m 39s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in IRC, you should revert your change to the RST file, because that file will be re-generated from the other changes (you won't see it regenerated until the process that makes that happen runs, which may be manual on release, I'm not sure for this collection).

The docs build that runs in the PR is showing you the changes it detected.

By following the link to the GitHub Actions run, you can find a link under "Artifacts" to download the generated HTML of the docs, and you can browse that locally to ensure that your changes were rendered correctly.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 58s
✔️ build-ansible-collection SUCCESS in 5m 32s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 12s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 52s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 52s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 39s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 38s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 19s
✔️ ansible-test-splitter SUCCESS in 2m 43s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

@ansibullbot
Copy link

@eRadical this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed community_review labels Sep 17, 2022
plugins/modules/cloudfront_distribution.py Outdated Show resolved Hide resolved
plugins/modules/cloudfront_distribution.py Outdated Show resolved Hide resolved
@ansibullbot
Copy link

@eRadical this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@softwarefactory-project-zuul
Copy link
Contributor

@goneri goneri changed the title + add connection_attempts & connection_timeout cloudfront_distribution: add connection_attempts and connection_timeout parameters Oct 25, 2022
@goneri
Copy link
Member

goneri commented Oct 25, 2022

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 42s
✔️ build-ansible-collection SUCCESS in 5m 40s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 51s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 16s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 41s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 46s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 04s
ansible-test-units-amazon-aws-python36 FAILURE in 6m 58s
ansible-test-units-amazon-aws-python38 FAILURE in 6m 05s
ansible-test-units-amazon-aws-python39 FAILURE in 6m 59s
✔️ ansible-test-splitter SUCCESS in 3m 25s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 19s

@goneri
Copy link
Member

goneri commented Oct 25, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 55s
✔️ build-ansible-collection SUCCESS in 6m 00s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 54s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 09s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 13m 21s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 34s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 37s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 49s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 04s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 06s
✔️ ansible-test-splitter SUCCESS in 2m 33s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 3m 14s

@goneri goneri added the mergeit Merge the PR (SoftwareFactory) label Oct 26, 2022
@goneri
Copy link
Member

goneri commented Oct 26, 2022

Thank you @eRadical.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 10s
✔️ build-ansible-collection SUCCESS in 5m 52s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 18s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 44s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 43s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 16s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 56s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 32s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 04s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 28s
✔️ ansible-test-splitter SUCCESS in 2m 48s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 26s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1e95b7f into ansible-collections:main Oct 26, 2022
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
new_module: backup_restore_job_info

SUMMARY

Adding a new module for getting restore job info.
Uses following boto3 APIs

list_restore_jobs
describe_restore_job


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

backup_restore_job_info
ADDITIONAL INFORMATION

Reviewed-by: Bikouo Aubin
Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Mike Graves <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs merge_commit This PR contains at least one merge commit. Please resolve! mergeit Merge the PR (SoftwareFactory) module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Each origin can have connection attempts & timeout
4 participants