-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudfront_distribution: add connection_attempts and connection_timeout parameters #1435
cloudfront_distribution: add connection_attempts and connection_timeout parameters #1435
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in IRC, you should revert your change to the RST file, because that file will be re-generated from the other changes (you won't see it regenerated until the process that makes that happen runs, which may be manual on release, I'm not sure for this collection).
The docs build that runs in the PR is showing you the changes it detected.
By following the link to the GitHub Actions run, you can find a link under "Artifacts" to download the generated HTML of the docs, and you can browse that locally to ensure that your changes were rendered correctly.
@eRadical this PR contains the following merge commits: Please rebase your branch to remove these commits. |
Co-authored-by: Brian Scholer <[email protected]>
Co-authored-by: Brian Scholer <[email protected]>
@eRadical this PR contains the following merge commits: Please rebase your branch to remove these commits. |
Hi @eRadical, Can you add a changelog fragment to your PR? https://docs.ansible.com/ansible/latest/community/development_process.html#creating-changelog-fragments |
recheck |
Thank you @eRadical. |
new_module: backup_restore_job_info SUMMARY Adding a new module for getting restore job info. Uses following boto3 APIs list_restore_jobs describe_restore_job ISSUE TYPE New Module Pull Request COMPONENT NAME backup_restore_job_info ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mike Graves <[email protected]>
Depends-On: #1569
SUMMARY
Missing connection_attempts & connection_timeout.
Closes #1434.
ISSUE TYPE
COMPONENT NAME
cloudfront_distribution