Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable network-firewall tests - slow enough to timeout #1396

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Aug 5, 2022

SUMMARY

The network-firewall tests take at least 45-50 minutes, due to how slow the firewalls themselves are to create/delete. While they are sporadically able to pass, as soon as things are running slightly slower we hit Zuul timeouts.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

network_firewall

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration needs_triage plugins plugin (any type) small_patch Hopefully easy to review tests tests labels Aug 5, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 02s
✔️ build-ansible-collection SUCCESS in 4m 48s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 21s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 12s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 03s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 07s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 56s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 00s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-community.aws-1 SUCCESS in 5m 23s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Aug 5, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 02s
✔️ build-ansible-collection SUCCESS in 5m 02s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 33s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 16s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 45s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 09s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 11s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 41s
✔️ ansible-test-splitter SUCCESS in 2m 38s
✔️ integration-community.aws-1 SUCCESS in 6m 02s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 68d2f1f into ansible-collections:main Aug 5, 2022
@tremble tremble added the backport-4 PR should be backported to the stable-4 branch label Aug 12, 2022
@patchback
Copy link

patchback bot commented Aug 12, 2022

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/68d2f1fac6d0060a7add3a7f771abdb9aafd8cce/pr-1396

Backported as #1411

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 12, 2022
Disable network-firewall tests - slow enough to timeout

SUMMARY
The network-firewall tests take at least 45-50 minutes, due to how slow the firewalls themselves are to create/delete.  While they are sporadically able to pass, as soon as things are running slightly slower we hit Zuul timeouts.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
network_firewall
ADDITIONAL INFORMATION

(cherry picked from commit 68d2f1f)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 12, 2022
[PR #1396/68d2f1fa backport][stable-4] Disable network-firewall tests - slow enough to timeout

This is a backport of PR #1396 as merged into main (68d2f1f).
SUMMARY
The network-firewall tests take at least 45-50 minutes, due to how slow the firewalls themselves are to create/delete.  While they are sporadically able to pass, as soon as things are running slightly slower we hit Zuul timeouts.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
network_firewall
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
@tremble tremble deleted the tests/disable/network-firewall branch September 9, 2022 09:01
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…llections#1419)

route53_info: fix "key error" for health_check operations

SUMMARY

Fixes ansible-collections#1396
This pull request

Add new return key health_check_observations for health check operations, returned when I(query=health_check) and I(health_check_method=status) or I(health_check_method=failure_reason)
Fixes "Key Error" when getting status or failure_reason of a health check.


ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

route53_info
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4 PR should be backported to the stable-4 branch bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) needs_triage plugins plugin (any type) small_patch Hopefully easy to review tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants