Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudwatchlogs_log_group: Add check_mode support #1373

Conversation

mandar242
Copy link
Contributor

SUMMARY

Add check_mode support to cloudwatchlogs_log_group.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

cloudwatchlogs_log_group

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 49s
✔️ build-ansible-collection SUCCESS in 4m 59s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 02s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 58s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 20s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 24s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 45s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 7m 12s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-community.aws-1 SUCCESS in 5m 50s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jul 27, 2022
@markuman
Copy link
Member

Just a changelog fragment is missing. otherwise LGTM

@markuman markuman added the backport-4 PR should be backported to the stable-4 branch label Jul 28, 2022
Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as you add a changelog fragment.

@goneri goneri added the mergeit Merge the PR (SoftwareFactory) label Jul 28, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 5m 11s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 00s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 06s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 51s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 34s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 00s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 44s
✔️ ansible-test-splitter SUCCESS in 2m 31s
✔️ integration-community.aws-1 SUCCESS in 6m 08s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6a85335 into ansible-collections:main Jul 28, 2022
@patchback
Copy link

patchback bot commented Jul 28, 2022

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/6a853354d2eb7f7fc39699a704161a0f93d4cdd7/pr-1373

Backported as #1374

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 28, 2022
cloudwatchlogs_log_group: Add check_mode support

SUMMARY

Add check_mode support to cloudwatchlogs_log_group.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

cloudwatchlogs_log_group

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 6a85335)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 29, 2022
[PR #1373/6a853354 backport][stable-4] cloudwatchlogs_log_group: Add check_mode support

This is a backport of PR #1373 as merged into main (6a85335).
SUMMARY

Add check_mode support to cloudwatchlogs_log_group.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

cloudwatchlogs_log_group

Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…#1373)

cloudwatchlogs_log_group: Add check_mode support

SUMMARY

Add check_mode support to cloudwatchlogs_log_group.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

cloudwatchlogs_log_group

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@6a85335
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Adds a pyproject.toml for default black/darker configuration
Adds a "Darker" github action which picks up on black linting issues for the sections of a file which have changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4 PR should be backported to the stable-4 branch community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants